Fixed and committed these:
this 'for' clause does not guard... [-Wmisleading-indentation]:
rgb2map.c:408:[Function:update_box]:
for (c0 = c0min; c0 <= c0max; c0++)
^~~
rgb2map.c:416:29: note: ...this statement, but the latter is
misleadingly indented as if it is guarded by the 'for'
boxp->colorcount = ccount;
^~~~
rgb2map.c:493:[Function:compute_color]:
for (c0 = c0min; c0 <= c0max; c0++)
^~~
rgb2map.c:506:5: note: ...this statement, but the latter is misleadingly
indented as if it is guarded by the 'for'
sl_colormap[0][icolor] = (JSAMPLE) ((c0total + (total>>1)) / total);
^~~~~~~~~~~
this 'if' clause does not guard... [-Wmisleading-indentation]:
intcgm/cd_intcgm.c:751:[Function:cdcgm_Counter]:
if (ret == CD_ABORT);
^~
intcgm/cd_intcgm.c:752:7: note: ...this statement, but the latter is
misleadingly indented as if it is guarded by the 'if'
return CGM_ABORT_COUNTER;
Best,
Scuri
2017-12-12 0:54 GMT-02:00 sur-behoffski <[email protected]>:
> G'day again,
>
> My previous message dealt with IUP, r4575.
>
> Here, in a similar fashion, is the output for CD, using Subversion
> tree revision 736.
>
> This output is possibly compromised, as the first step, creating the
> dependencies, cannot find a freetype2 header file:
>
> "#include "ft2build.h"
>
> I've confirmed that this header file is installed by both Gentoo
> (my system) and in a Ubuntu-derivative system in:
>
> "/usr/include/freetype2"
>
> As per the CD build instructions, the header file was not present
> in the Ubuntu-derivative system by default (I believe that only
> the link library was included), but, when "libfreetype6-dev" was
> installed, then it did appear in "/usr/include/freetype2".
>
> NOTE HOWEVER, that the "-Wmisleading-indentation" diagnostic is a
> result of the Apple "goto Fail;" bug, where critical checking in the
> setup of SSL (https://) links was skipped, due to an extraneous
> statement that meant that vital checks were omitted. If you read up
> on this bug, at places such as:
>
> "The Apple goto fail vulnerability: lessons learned"
> by David A. Wheeler:
> https://www.dwheeler.com/essays/apple-goto-fail.html
>
> "Anatomy of a goto fail" -- Apple's SSL bug explained...
> https://nakedsecurity.sophos.com/2014/02/24/anatomy-of-a-got
> o-fail-apples-ssl-bug-explained-plus-an-unofficial-patch/
>
> You can see code snippets, along the lines of:
>
> hashOut.data = hashes + SSL_MD5_DIGEST_LEN;
> hashOut.length = SSL_SHA1_DIGEST_LEN;
> if ((err = SSLFreeBuffer(&hashCtx)) != 0)
> goto fail;
> if ((err = ReadyHash(&SSLHashSHA1, &hashCtx)) != 0)
> goto fail;
> if ((err = SSLHashSHA1.update(&hashCtx, &clientRandom)) != 0)
> goto fail;
> if ((err = SSLHashSHA1.update(&hashCtx, &serverRandom)) != 0)
> goto fail;
> if ((err = SSLHashSHA1.update(&hashCtx, &signedParams)) != 0)
> goto fail;
> goto fail; /* MISTAKE! THIS LINE SHOULD NOT BE HERE */
> if ((err = SSLHashSHA1.final(&hashCtx, &hashOut)) != 0)
> goto fail;
>
> err = sslRawVerify(...);
>
> As a result of this, GCC 6 added the "misleading indentation"
> diagnostic -- and I'm using gcc 6.4.0 for this build. So, ignore the
> diagnostic from the gcc compiler, and picked up in my diagnostics
> summary, at your peril.
>
> Anyway, following is the summary for CD, Subversion revision 736.
>
> cheers,
>
> sur-behoffski etc.
>
>
>
> ------------------ cut here ------------------
>
>
> implicit declaration of function <FUNC> [-Wimplicit-function-declaration]:
>
>
> ignoring return value of <FUNC>, declared with attribute
> warn_unused_result [-Wunused-result]:
> intcgm/cgm_txt_get.c:10:[Function:cgm_txt_get_sep]: fscanf
> intcgm/cgm_txt_get.c:26:[Function:cgm_txt_skip_com]: fscanf
> intcgm/cgm_txt_get.c:37:[Function:cgm_txt_skip_parentheses]: fscanf
> intcgm/cgm_txt_get.c:48:[Function:cgm_txt_get_ter_noerr]: fscanf
> intcgm/cgm_txt_get.c:107:[Function:cgm_txt_get_e]: fscanf
> drv/cdmf.c:770:[Function:cdplay]: fscanf
> drv/cdmf.c:801:[Function:cdplay]: fscanf
> drv/cdmf.c:814:[Function:cdplay]: fscanf
> drv/cdmf.c:818:[Function:cdplay]: fscanf
> drv/cdmf.c:822:[Function:cdplay]: fscanf
> drv/cdmf.c:826:[Function:cdplay]: fscanf
> drv/cdmf.c:833:[Function:cdplay]: fscanf
> drv/cdmf.c:837:[Function:cdplay]: fscanf
> drv/cdmf.c:841:[Function:cdplay]: fscanf
> drv/cdmf.c:845:[Function:cdplay]: fscanf
> drv/cdmf.c:849:[Function:cdplay]: fscanf
> drv/cdmf.c:853:[Function:cdplay]: fscanf
> drv/cdmf.c:857:[Function:cdplay]: fscanf
> drv/cdmf.c:861:[Function:cdplay]: fscanf
> drv/cdmf.c:865:[Function:cdplay]: fscanf
> drv/cdmf.c:869:[Function:cdplay]: fscanf
> drv/cdmf.c:873:[Function:cdplay]: fscanf
> drv/cdmf.c:877:[Function:cdplay]: fscanf
> drv/cdmf.c:881:[Function:cdplay]: fscanf
> drv/cdmf.c:885:[Function:cdplay]: fscanf
> drv/cdmf.c:889:[Function:cdplay]: fscanf
> drv/cdmf.c:893:[Function:cdplay]: fscanf
> drv/cdmf.c:897:[Function:cdplay]: fscanf
> drv/cdmf.c:901:[Function:cdplay]: fscanf
> drv/cdmf.c:905:[Function:cdplay]: fscanf
> drv/cdmf.c:909:[Function:cdplay]: fscanf
> drv/cdmf.c:913:[Function:cdplay]: fscanf
> drv/cdmf.c:917:[Function:cdplay]: fscanf
> drv/cdmf.c:921:[Function:cdplay]: fscanf
> drv/cdmf.c:925:[Function:cdplay]: fscanf
> drv/cdmf.c:929:[Function:cdplay]: fscanf
> drv/cdmf.c:933:[Function:cdplay]: fscanf
> drv/cdmf.c:940:[Function:cdplay]: fscanf
> drv/cdmf.c:944:[Function:cdplay]: fscanf
> drv/cdmf.c:948:[Function:cdplay]: fscanf
> drv/cdmf.c:952:[Function:cdplay]: fscanf
> drv/cdmf.c:956:[Function:cdplay]: fscanf
> drv/cdmf.c:960:[Function:cdplay]: fscanf
> drv/cdmf.c:964:[Function:cdplay]: fscanf
> drv/cdmf.c:968:[Function:cdplay]: fscanf
> drv/cdmf.c:972:[Function:cdplay]: fscanf
> drv/cdmf.c:975:[Function:cdplay]: fscanf
> drv/cdmf.c:980:[Function:cdplay]: fscanf
> drv/cdmf.c:984:[Function:cdplay]: fscanf
> drv/cdmf.c:988:[Function:cdplay]: fscanf
> drv/cdmf.c:992:[Function:cdplay]: fscanf
> drv/cdmf.c:998:[Function:cdplay]: fscanf
> drv/cdmf.c:1005:[Function:cdplay]: fscanf
> drv/cdmf.c:1011:[Function:cdplay]: fscanf
> drv/cdmf.c:1018:[Function:cdplay]: fscanf
> drv/cdmf.c:1023:[Function:cdplay]: fscanf
> drv/cdmf.c:1027:[Function:cdplay]: fscanf
> drv/cdmf.c:1031:[Function:cdplay]: fscanf
> drv/cdmf.c:1035:[Function:cdplay]: fscanf
> drv/cdmf.c:1039:[Function:cdplay]: fscanf
> drv/cdmf.c:1043:[Function:cdplay]: fscanf
> drv/cdmf.c:1047:[Function:cdplay]: fscanf
> drv/cdmf.c:1051:[Function:cdplay]: fscanf
> drv/cdmf.c:1058:[Function:cdplay]: fscanf
> drv/cdmf.c:1062:[Function:cdplay]: fscanf
> drv/cdmf.c:1066:[Function:cdplay]: fscanf
> drv/cdmf.c:1073:[Function:cdplay]: fscanf
> drv/cdmf.c:1084:[Function:cdplay]: fscanf
> drv/cdmf.c:1092:[Function:cdplay]: fscanf
> drv/cdmf.c:1105:[Function:cdplay]: fscanf
> drv/cdmf.c:1111:[Function:cdplay]: fscanf
> drv/cdmf.c:1119:[Function:cdplay]: fscanf
> drv/cdmf.c:1127:[Function:cdplay]: fscanf
> drv/cdmf.c:1131:[Function:cdplay]: fscanf
> drv/cdmf.c:1138:[Function:cdplay]: fscanf
> drv/cdmf.c:1149:[Function:cdplay]: fscanf
> drv/cdmf.c:1157:[Function:cdplay]: fscanf
> drv/cdmf.c:1170:[Function:cdplay]: fscanf
> drv/cdmf.c:1176:[Function:cdplay]: fscanf
> drv/cdmf.c:1184:[Function:cdplay]: fscanf
> drv/cdmf.c:1192:[Function:cdplay]: fscanf
> drv/cdmf.c:1196:[Function:cdplay]: fscanf
> drv/cdmf.c:1200:[Function:cdplay]: fscanf
> drv/cdmf.c:1204:[Function:cdplay]: fscanf
> drv/cdmf.c:1208:[Function:cdplay]: fscanf
> drv/cdmf.c:1212:[Function:cdplay]: fscanf
> drv/cdmf.c:1216:[Function:cdplay]: fscanf
> drv/cdmf.c:1220:[Function:cdplay]: fscanf
> drv/cdmf.c:1224:[Function:cdplay]: fscanf
> drv/cdmf.c:1228:[Function:cdplay]: fscanf
> drv/cdmf.c:1232:[Function:cdplay]: fscanf
> drv/cdmf.c:1236:[Function:cdplay]: fscanf
> drv/cdmf.c:1240:[Function:cdplay]: fscanf
> drv/cdmf.c:1244:[Function:cdplay]: fscanf
> drv/cdmf.c:1248:[Function:cdplay]: fscanf
>
>
> <FUNC> defined but not used [-Wunused-function]:
>
>
> cast to pointer from integer of different size [-Wint-to-pointer-cast]:
>
>
> cast from pointer to integer of different size [-Wpointer-to-int-cast]:
>
>
> no return statement in function returning non-void [-Wreturn-type]:
>
>
> <VAR> defined but not used [-Wunused-variable]:
>
>
> variable <VAR> set but not used [-Wunused-but-set-variable]:
>
>
> <VAR> will be initialized after [-Wreorder]:
>
>
> <VAR> is usually a function [-Wmain]:
>
>
> deprecated conversion from string constant to <TYPE> [-Wwrite-strings]:
>
>
> format <FMT> expects argument of type <TYPE1>, but argument <NUM> has type
> <TYPE2> [-Wformat=]:
>
>
> comparison between <ENUM1> and <ENUM2> [-Wenum-compare]:
>
>
> statement with no effect [-Wunused-value]:
>
>
> the use of `tmpnam' is dangerous, better use `mkstemp':
>
>
> case value <LABEL> not in enumerated type <ENUM> [-Wswitch]:
>
>
> suggest parentheses around assignment used as truth value [-Wparentheses]:
>
>
> suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]:
>
>
> this 'for' clause does not guard... [-Wmisleading-indentation]:
> rgb2map.c:408:[Function:update_box]:
> for (c0 = c0min; c0 <= c0max; c0++)
> ^~~
> rgb2map.c:416:29: note: ...this statement, but the latter is
> misleadingly indented as if it is guarded by the 'for'
> boxp->colorcount = ccount;
> ^~~~
> rgb2map.c:493:[Function:compute_color]:
> for (c0 = c0min; c0 <= c0max; c0++)
> ^~~
> rgb2map.c:506:5: note: ...this statement, but the latter is
> misleadingly indented as if it is guarded by the 'for'
> sl_colormap[0][icolor] = (JSAMPLE) ((c0total + (total>>1)) /
> total);
> ^~~~~~~~~~~
>
>
> this 'if' clause does not guard... [-Wmisleading-indentation]:
> intcgm/cd_intcgm.c:751:[Function:cdcgm_Counter]:
> if (ret == CD_ABORT);
> ^~
> intcgm/cd_intcgm.c:752:7: note: ...this statement, but the latter is
> misleadingly indented as if it is guarded by the 'if'
> return CGM_ABORT_COUNTER;
> ^~~~~~
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Iup-users mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/iup-users
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Iup-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/iup-users
