[Iup-users] IUP 3.24 DEADCODE AND NULL RETURNS (iupwin_dragdrop.c)

[Ranier VF]

Hi,
Issues found by Coverity Scan.
CID 259204 (#1 of 1): Logically dead code (DEADCODE)
CID 259217 (#2 of 2): Dereference null return value (NULL_RETURNS)

--- a\src\win\iupwin_dragdrop.c Mon Dec 11 14:52:42 2017
+++ b\src\win\iupwin_dragdrop.c Wed Jan 24 22:52:48 2018
@@ -418,7 +418,10 @@
 
   /* fill data */
   cbDragData = (IFnsVi)IupGetCallback(pThis->ih, "DRAGDATA_CB");
-  cbDragData(pThis->ih, iupwinStrFromSystem(type), pData, size);
+  if (cbDragData)
+  {
+    cbDragData(pThis->ih, iupwinStrFromSystem(type), pData, size);
+  }
 
   GlobalUnlock(pStgMedium->hGlobal);
 
@@ -794,8 +797,6 @@
     lstrcpy(name, TEXT("BITMAP"));
   else if (cf == CF_METAFILEPICT)
     lstrcpy(name, TEXT("METAFILEPICT"));
-  else if (cf == CF_TIFF)
-    lstrcpy(name, TEXT("TIFF"));
   else if (cf == CF_TIFF)
     lstrcpy(name, TEXT("TIFF"));
   else if (cf == CF_DIB)

Best,
Ranier Vilela

iupwin_dragdrop.patch
Description: iupwin_dragdrop.patch

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Iup-users mailing list
Iup-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/iup-users