*1. src/iup_elempropdlg.c& operator is dangerous, need parentheses to
clarify expression.*
OK
*2. iup_flatscrollbar.c!show_transparent test is always true, can be secure
removed.*
OK
*3. src/iup_gauge.cNot sure, IupDrawEnd(ih); is missing call?*
Yes, it was missing. Thanks.
*4. src/iup_image.cNonsense code? Or is another logic?*
Was nonsense...
*5. src/win/iupwin_filedlg.cOptimized test is buffer (char *) is empty.*
OK
*6. src/win/iupwin_touch.cBug? ti->dwID? *
Yes, a bug. Thanks.
*7. src\win\iupwin_fontdlg.c (195)height_pixels = logfont.lfHeight; <-
reassigned value?*
That's correct. The logfont structure is changed inside ChooseFont, so
after the call we assign the new value.
*8. src\win\iupwin_key.c (105) map[VK_OEM_PLUS].iupcode =
LOWORD(MapVirtualKeyA(VK_OEM_PLUS, MAPVK_VK_TO_CHAR));
map[VK_OEM_COMMA].iupcode = LOWORD(MapVirtualKeyA(VK_OEM_COMMA,
MAPVK_VK_TO_CHAR)); map[VK_OEM_MINUS].iupcode =
LOWORD(MapVirtualKeyA(VK_OEM_MINUS, MAPVK_VK_TO_CHAR));
map[VK_OEM_PERIOD].iupcode = LOWORD(MapVirtualKeyA(VK_OEM_PERIOD,
MAPVK_VK_TO_CHAR));vars reassigned?*
Just comment these lines.
*9. src\win\iupwin_list.c (1424)WM_CLEAR and WM_CUT perform the same
action?*
Yes, they do, in that context. I just merged the two conditions.
*10. srccontrols\matrix\iupmat_aux.c (136)Test not make sense. if (index
== p->num) { if (p->num == p->num_noscroll) { /* did NOT go
trough the "for" above */ offset = scroll_pos; index =
p->num_noscroll; <- same value?If index == p->num and p->num ==
p->num_poscroll, index is equal p->num_noscroll. *
The test makes sense, the attribution is redundant. It is there just for
clarity. I added a comment.
All changes committed to the SVN.
Best,
Scuri
Em ter., 7 de jul. de 2020 às 10:48, Ranier Vilela <[email protected]>
escreveu:
> 7. src\win\iupwin_fontdlg.c (195)
> height_pixels = logfont.lfHeight; <- reassigned value?
>
> 8. src\win\iupwin_key.c (105)
> map[VK_OEM_PLUS].iupcode = LOWORD(MapVirtualKeyA(VK_OEM_PLUS,
> MAPVK_VK_TO_CHAR));
> map[VK_OEM_COMMA].iupcode = LOWORD(MapVirtualKeyA(VK_OEM_COMMA,
> MAPVK_VK_TO_CHAR));
> map[VK_OEM_MINUS].iupcode = LOWORD(MapVirtualKeyA(VK_OEM_MINUS,
> MAPVK_VK_TO_CHAR));
> map[VK_OEM_PERIOD].iupcode = LOWORD(MapVirtualKeyA(VK_OEM_PERIOD,
> MAPVK_VK_TO_CHAR));
> vars reassigned?
>
> 9. src\win\iupwin_list.c (1424)
> WM_CLEAR and WM_CUT perform the same action?
>
> 10. srccontrols\matrix\iupmat_aux.c (136)
> Test not make sense.
> if (index == p->num)
> {
> if (p->num == p->num_noscroll)
> {
> /* did NOT go trough the "for" above */
> offset = scroll_pos;
> index = p->num_noscroll; <- same value?
>
> If index == p->num and p->num == p->num_poscroll, index is equal
> p->num_noscroll.
>
> regards,
> Ranier Vilela
>
>
> _______________________________________________
> Iup-users mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/iup-users
>
_______________________________________________
Iup-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/iup-users
