On Monday 08 May 2006 17:30, Bryan Mayland wrote:
> Hans Verkuil wrote:
> > - Remove broken fast firmware load from cx25840.
>
>     My bad!  What was wrong with doing what I did, simply out of
> curiosity?

This line simply won't work:

struct i2c_algo_bit_data *algod = client->adapter->algo_data;

The contents of algo_data is private to the adapter. This code only 
works when using the default i2c adapter. When another adapter is used 
this is no longer valid. It hasn't worked for quite some time now with 
ivtv (ever since the ivtv-specific adapter was introduced to fix reset 
problems with the IR blaster) and it corrupted internal data when used 
with the adapter in pvrusb2.

Since the actual load time gained is not all the big I thought it wise 
to remove it altogether.

What I would really like to see is some mechanism of loading the 
firmware as a background process. I did some experiments, but it 
already turns out that that isn't as easy as I thought.

        Hans

_______________________________________________
ivtv-devel mailing list
[email protected]
http://ivtvdriver.org/mailman/listinfo/ivtv-devel

Reply via email to