On Tuesday 19 December 2006 09:18, Kyuma Ohta wrote:
> Hi,
>  I tested build ivtv-driver svn head (v0.10-r3695)
> with vanilla kernel 2.6.20-rc1.
>
> But, cause of change of macro : INIT_WORK() ,
> compilation of ivtv-driver was failed.
>
> # With 2.6.19 series,working well now,
> # but newer firmware is needed ;-)
>
>
> So,I made test patch for *only* 2.6.20 series.
> Please test working.

--- ivtv-driver.c.orig  2006-12-19 07:24:39.000000000 +0900
+++ ivtv-driver.c.2.6.20-rc1    2006-12-19 07:42:12.000000000 +0900
@@ -622,8 +622,9 @@
                IVTV_ERR("Could not create VBI workqueue\n");
                return -1;
        }
-       INIT_WORK(&itv->vbi.work_queue, vbi_work_handler, itv);
-
+       //INIT_WORK(&itv->vbi.work_queue, vbi_work_handler, itv);
+        INIT_WORK(&itv->vbi.work_queue, vbi_work_handler); // 2.6.20+ 
20061219 K.Ohta
+   
        /* start counting open_id at 1 */
        itv->open_id = 1;

Sorry, but that can't be the full fix: that itv pointer must be passed 
to the work queue somehow! Anyway, I generally wait until the kernel is 
released before adapting ivtv trunk to that new kernel. Otherwise 
people cannot use the trunk unless they also upgrade to a test kernel.

Thanks,

        Hans

_______________________________________________
ivtv-devel mailing list
[email protected]
http://ivtvdriver.org/mailman/listinfo/ivtv-devel

Reply via email to