On Mon, 28 Apr 2008 22:40:42 +0200 Hans Verkuil <[EMAIL PROTECTED]> wrote:
> On Monday 28 April 2008 15:48:19 Mauro Carvalho Chehab wrote: > > On Sun, 27 Apr 2008 12:55:11 +0200 > > > > Hans Verkuil <[EMAIL PROTECTED]> wrote: > > > Hi Mauro, > > > > > > Please pull from http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-cx18 > > > for the following: > > > > How! a very big changeset. Probably, I'll miss some things. I have > > just a few comments about the first patch. Thanks for your good work! > > > > > - cx18: new driver for the Conexant CX23418 MPEG encoder chip > > > > Hmm... this seems to be wrong. IMO, it should be just the opposite. > > No, this is right. Only request the module if it is not compiled into > the kernel. Ah, ok. It is safe to remove those ifs. This is how request_module is defined at kernel headers: #ifdef CONFIG_KMOD /* modprobe exit status on success, -ve on error. Return value * usually useless though. */ extern int request_module(const char * name, ...) __attribute__ ((format (printf, 1, 2))); #else static inline int request_module(const char * name, ...) { return -ENOSYS; } #endif > I'll post a new PULL request. Got the pull request. I'll handle it right now. If you decide, you may later remove the #if's. Cheers, Mauro _______________________________________________ ivtv-devel mailing list [email protected] http://ivtvdriver.org/mailman/listinfo/ivtv-devel
