On Sun, 01 Jun 2008 15:01:59 -0400 Andy Walls <[EMAIL PROTECTED]> wrote:
> On Sun, 2008-06-01 at 12:15 +0200, Hans Verkuil wrote: > > > > Thanks Andy! > > > > I'll take a closer look on Tuesday or Wednesday, but I noticed one > > thing: you set unused callbacks to NULL in cx18_set_funcs(), however > > these can just be removed as they are NULL by default. > > Yeah, they can go. I left them in as an aid for double checking that I > didn't forget any callbacks that needed to be implemented. Please don't do that. All static vars that have a value 0 or NULL shouldn't be initialized, since this will eat some space inside the module. Cheers, Mauro _______________________________________________ ivtv-devel mailing list [email protected] http://ivtvdriver.org/mailman/listinfo/ivtv-devel
