On Fri, 2008-08-08 at 16:35 +0200, Hans Verkuil wrote: > On Friday 08 August 2008 16:18:28 Andy Walls wrote:
> No objection at all. If you look at where cx18_queue_move is used, then > you'll notice that it is only in cx18_flush_queues(). And all it has to > do there is to move any buffers in the q_io or q_full queue to the > q_free queue and initialize all those buffers to their initial state. > You do not need all that complicated code for that. I suggest that you > make a new function instead that replaces cx18_queue_move and > cx18_queue_move_buf. :) I was especially annoyed at the local var that was named 'from_free' but that was also used being for transfers *to* q_free, which happened to be cx18's only use case for the variable.,,, Regards, Andy > Regards, > > Hans > _______________________________________________ ivtv-devel mailing list [email protected] http://ivtvdriver.org/mailman/listinfo/ivtv-devel
