On Sun, 01 Mar 2009 22:04:55 -0500 Andy Walls <[email protected]> wrote:
> Mauro, > > Please pull from > > http://linuxtv.org/hg/~awalls/cx18 > > for the following > > cx18: Add interlock so sliced VBI insertion only happens for an MPEG PS > cx18: Fix VPS service register code and ensure VBI consistentcy with ivtv Argh! This is really ugly! + +#include <linux/ivtv.h> /* For IVTV_SLICED_TYPE_* */ + Why do you need to include a header for a device that has nothing to do with cx18? This doesn't belong here... If those VBI parameters should be global to all devices, then it should be, instead, at some subsystem header, and your patch should also touch on the other drivers. Cheers, Mauro _______________________________________________ ivtv-devel mailing list [email protected] http://ivtvdriver.org/mailman/listinfo/ivtv-devel
