On Tue, 2009-12-01 at 15:29 -0500, Argus wrote:
> On Tue, 1 Dec 2009, Moasat wrote:
>
> Moasat,
>
> I haven't tried this, but it should extend the hack to include 350 cards
> as well as 150/500 cards. I wasn't aware that the tinny audio afflicts
> other Hauppauge models (does this happen on 250's, too?) I only own
> 150's, so that is where I was concentrating my debugging efforts.
The PVR-250 and PVR-350 are different. They have a SAA7115 for video
and an MSP34xx (IIRC) for audio and not a CX2584x. However, it appears
the saa7115_s_stream() function in saa7115.c enables/disables the video
clock. The msp3400-driver.c doesn't seem to have any s_stream()
function, so it shouldn't matter.
> I've found that setting the audio-in wasn't very effective in my
> setup. I still had the occassional recording corruption. Better to
> fix it at the driver level anyway, I think (hope). We shouldn't need
> external workarounds ...
>
> If you get a chance, please give it a try. I'd be curious if it works.
> I assume Andy/Hans would be interested, too ...
I am interested. I was hoping Hans, Chris. or Tyler had some insight
into the history of why floating the digitizer outputs was thought to be
needed for the CX25843 at one point in history.
Regards,
Andy
> PATCH w/350:
> ========================================================================
> --- drivers/media/video/ivtv/ivtv-streams.c.original 2008-12-24
> 18:26:37.000000000 -0500
> +++ drivers/media/video/ivtv/ivtv-streams.c 2009-12-01 15:16:11.795973690
> -0500
> @@ -575,15 +575,23 @@
> ivtv_set_irq_mask(itv, IVTV_IRQ_MASK_CAPTURE);
>
> clear_bit(IVTV_F_I_EOS, &itv->i_flags);
>
> /* Initialize Digitizer for Capture */
> + if (itv->card->type != IVTV_CARD_PVR_150 &&
> + itv->card->type != IVTV_CARD_PVR_350) {
> itv->video_dec_func(itv, VIDIOC_STREAMOFF, NULL);
> ivtv_msleep_timeout(300, 1);
> + }
> +
> ivtv_vapi(itv, CX2341X_ENC_INITIALIZE_INPUT, 0);
> +
> + if (itv->card->type != IVTV_CARD_PVR_150 &&
> + itv->card->type != IVTV_CARD_PVR_350) {
> itv->video_dec_func(itv, VIDIOC_STREAMON, NULL);
> }
> + }
>
> /* begin_capture */
> if (ivtv_vapi(itv, CX2341X_ENC_START_CAPTURE, 2, captype, subtype))
> {
> IVTV_DEBUG_WARN( "Error starting capture!\n");
>
> ========================================================================
>
> - Argus
>
>
> _______________________________________________
> ivtv-devel mailing list
> [email protected]
> http://ivtvdriver.org/mailman/listinfo/ivtv-devel
>
_______________________________________________
ivtv-devel mailing list
[email protected]
http://ivtvdriver.org/mailman/listinfo/ivtv-devel
