D. Hugh Redelmeier <[EMAIL PROTECTED]> wrote:

There has been only one submitted change to that file since the last
release, so I figured now was a good time.

> /usr/src/linux/Documentation/CodingStyle specifies the kernel coding
> style, and this module is intended to be part of the kernel. As it
> suggests, you used /usr/src/linux/scripts/lindent.  What did you find
> it necessary to fix up?  Is there any set of flags that can automate
> this?

There are some case statements that are tiny and easier to read if folded up:
case x: foo = bar; break;

Basically nothing important.  The things I changed seem to survive
subsequent runnings  of indent (except the above noted).

> (When I did indent myself, there were a lot of lines that were deeply
> indented and broken up very badly by smashing into column 80.  I think
> that the code looks better with 4 space indentation rather than 8, but
> that is not acceptable.)

I used -cbi0 so that the stuff inside the case statements don't end up
getting double-indented.

Also, I added ';' to the end of the register settings so that indent
didn't mess everything up.  They read better that way anyway.
-- 
Tyler Trafford


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
ivtv-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ivtv-devel

Reply via email to