Bryan Mayland wrote:

> Finally figured out what was causing the high pitched audio whine in all
> my recordings.  Revision 200 (0.3.4m) added proper setup of the audio.
> If I wrote a quick test app that would use v4l2 ioctls to set
> V4L2_CID_IVTV_FREQ, sound would work perfectly.  Quickly traced it down
> to ivtv_audio_set_bitrate(), which should be called from the S_CODEC
> ioctl.  It was not doing anything for PVR150s or CX25840s.

Oh good.

I've been looking at the cx25840 code a lot, but it wasn't until this
past week that I thought to look at how it was being called... :)

> This patch probably should be modified so that both types call the same
> function, but I took the safe route.

Yeah, the call should probably be under USE_CX25840, and USE_PVR150
should fall through to it.  I've done that with the audio_input code
too, broken up to separate the chip specific stuff from the card
specific stuff.

There's more I'd like to do there, hopefully someone with a PG600
(Diamond PVR550) will volunteer to test so that I don't break the
non-PVR150s that use the cx25840.
-- 
Tyler Trafford


-------------------------------------------------------
This SF.Net email is sponsored by Oracle Space Sweepstakes
Want to be the first software developer in space?
Enter now for the Oracle Space Sweepstakes!
http://ads.osdn.com/?ad_ids93&alloc_id281&op=click
_______________________________________________
ivtv-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ivtv-devel

Reply via email to