Hi folks, I just started messing intensely with IVTV, so please bare with me. :)
This is my first patch, and I'm fairly clueless, so be warned. I think I'm just fixing some typos. My target platform is x86 with Linux 2.4.30 and uClibc 0.9.20. I've gotten 0.3.6q and a couple other versions that I've tried to compile fine. Using 0.3.6r through 0.3.6v I get a compile error as follows: --- begin --- /usr/bin/gcc -D__KERNEL__ -D__KERNEL_SYSCALLS__ -DMODULE -DMODVERSIONS -DEXPORT_SYMTAB -I/source/linux/linux/include -O2 -fomit-frame-pointer -march=i586 -mcpu=i586 -fno-strict-aliasing -Wno-unused -include /source/linux/linux/include/linux/modversions.h -c -o ivtv-driver.o ivtv-driver.c ivtv-driver.c:217: error: parse error before "i" ivtv-driver.c:218: error: parse error before "i" ivtv-driver.c:219: error: parse error before "i" ivtv-driver.c:220: error: parse error before "i" ivtv-driver.c:221: error: parse error before "i" ivtv-driver.c:222: error: parse error before "i" ivtv-driver.c:223: error: parse error before "i" ivtv-driver.c:224: error: parse error before "i" ivtv-driver.c:226: error: parse error before "i" ivtv-driver.c:227: error: parse error before "i" ivtv-driver.c:228: error: parse error before "i" ivtv-driver.c:229: error: parse error before "i" ivtv-driver.c:230: error: parse error before "i" ivtv-driver.c:231: error: parse error before "i" ivtv-driver.c:232: error: parse error before "i" ivtv-driver.c:233: error: parse error before "i" ivtv-driver.c:297: error: redefinition of `__module_parm_desc_max_vbi_buffers' ivtv-driver.c:291: error: `__module_parm_desc_max_vbi_buffers' previously defined here make[1]: *** [ivtv-driver.o] Error 1 make[1]: Leaving directory `/source/ivtv/ivtv-0.3.6r/driver' make: *** [.build] Error 2 make: Leaving directory `/source/ivtv' --- end --- The attached patch fixes things for me. Please let me know if you need anything else. I'd be happy to do testing specific to uClibc if anyone is interested. - Justin
diff -Naur ivtv-0.3.6v-orig/driver/ivtv-driver.c ivtv-0.3.6v/driver/ivtv-driver.c > ivtv-compile-problem-20050629.patch --- ivtv-0.3.6v-orig/driver/ivtv-driver.c 2005-06-29 13:45:56.000000000 -0400 +++ ivtv-0.3.6v/driver/ivtv-driver.c 2005-06-29 13:42:26.000000000 -0400 @@ -214,23 +214,23 @@ MODULE_PARM(ivtv_dfw, "s"); MODULE_PARM(ivtv_first_minor, "i"); -MODULE_PARM(mpg_buffers, i); -MODULE_PARM(yuv_buffers, i); -MODULE_PARM(vbi_buffers, i); -MODULE_PARM(pcm_buffers, i); -MODULE_PARM(dec_mpg_buffers, i); -MODULE_PARM(dec_yuv_buffers, i); -MODULE_PARM(dec_vbi_buffers, i); -MODULE_PARM(dec_osd_buffers, i); - -MODULE_PARM(max_mpg_buffers, i); -MODULE_PARM(max_yuv_buffers, i); -MODULE_PARM(max_vbi_buffers, i); -MODULE_PARM(max_pcm_buffers, i); -MODULE_PARM(max_dec_mpg_buffers, i); -MODULE_PARM(max_dec_yuv_buffers, i); -MODULE_PARM(max_dec_vbi_buffers, i); -MODULE_PARM(max_dec_osd_buffers, i); +MODULE_PARM(mpg_buffers, "i"); +MODULE_PARM(yuv_buffers, "i"); +MODULE_PARM(vbi_buffers, "i"); +MODULE_PARM(pcm_buffers, "i"); +MODULE_PARM(dec_mpg_buffers, "i"); +MODULE_PARM(dec_yuv_buffers, "i"); +MODULE_PARM(dec_vbi_buffers, "i"); +MODULE_PARM(dec_osd_buffers, "i"); + +MODULE_PARM(max_mpg_buffers, "i"); +MODULE_PARM(max_yuv_buffers, "i"); +MODULE_PARM(max_vbi_buffers, "i"); +MODULE_PARM(max_pcm_buffers, "i"); +MODULE_PARM(max_dec_mpg_buffers, "i"); +MODULE_PARM(max_dec_yuv_buffers, "i"); +MODULE_PARM(max_dec_vbi_buffers, "i"); +MODULE_PARM(max_dec_osd_buffers, "i"); #endif @@ -294,7 +294,7 @@ MODULE_PARM_DESC(pcm_buffers, "Enc PCM buffers (in megs)\n" "\t\t\t Default: " IVTV_DEFAULT_PCM_BUFFERS_CNT); -MODULE_PARM_DESC(max_vbi_buffers, +MODULE_PARM_DESC(max_pcm_buffers, "Max Enc PCM Buffers (in megs)\n" "\t\t\t Default: " IVTV_MAX_PCM_BUFFERS_CNT); MODULE_PARM_DESC(dec_mpg_buffers,
