Re: [ivtv-devel] Kernel Oops, NULL pointer dereference, with 0.3.7e, 0.3.7f

[Hans Verkuil]

On Wednesday 17 August 2005 22:20, Erik Toubro Nielsen wrote:
> When running
>    ivtv-0.3.7f/test/vbi
> the below oops happens.
>
> Card is a PVR-500. Kernel is SuSE 2.6.11.4-21.7-default.
>
> I cannot make this error happen with 0.3.7d.

I'll bet that the attached patch will fix this. I came across this bug 
yesterday while going through the source. And it's also in 0.3.7d and 
probably has been there from the start :-)

                        Hans

--- ivtv-fileops.c.org	2005-08-18 21:42:31.000000000 +0200
+++ ivtv-fileops.c	2005-08-18 21:42:43.000000000 +0200
@@ -216,12 +216,12 @@
 int ivtv_reset_digitizer(struct ivtv *itv)
 {
 	int x = 0, ret = 0;
-	unsigned int *arg = 0;
+	unsigned int arg = 0;
 
 	if (itv->card->type == IVTV_CARD_PVR_150 ||
                     itv->card->type == IVTV_CARD_PG600) 
 	{
-		ivtv_cx25840(itv, DECODER_GET_VIDEO_STATUS, arg);
+		ivtv_cx25840(itv, DECODER_GET_VIDEO_STATUS, &arg);
 		if (!arg)	
 			IVTV_DEBUG_WARN("Digitizer video is bad\n");
 	}