On Sunday 28 August 2005 22:34, Philip Rowlands wrote:
> $ gcc -v
> gcc version 4.0.1 20050727 (Red Hat 4.0.1-5)
>
> $ make
> /root/ivtv-0.3.7k/driver/ivtv-vbi.c: In function "passthrough_vbi_data":
> /root/ivtv-0.3.7k/driver/ivtv-vbi.c:184: warning: "vps[2]" is used
> uninitialized in this function
>
> The relevent code is here:
>
> 182 if (found_vps || itv->vbi_vps_found) {
> 183 down(&itv->vbi_dec_lock);
> 184 itv->vbi_vps[0] = vps[2];
> 185 itv->vbi_vps[1] = vps[8];
> 186 itv->vbi_vps[2] = vps[9];
> 187 itv->vbi_vps[3] = vps[10];
> 188 itv->vbi_vps[4] = vps[11];
> 189 itv->vbi_vps_found = found_vps;
> 190 up(&itv->vbi_dec_lock);
> 191 change = 1;
> 192 }
>
> and as far as I can see, the array vps[] is not initialized or used
> outside of that function. There's one warning per vps[] RHS (lines
> 184-188).
>
> This may be harmless, but it generates a scary-looking warning. Hans?
Fixed for 0.3.7l. The vps array should be copied from the arriving VBI data.
Since I moved vps decoding to the encoder chips I forgot that I still had to
fill the vps array.
Thanks!
Hans
-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
ivtv-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ivtv-devel
