Xavier,

I've moved the XmlReportOutputter.getReportFileName method to the CacheManager. 
I think all files that are put in the cache or retrieved from the cache should 
go through the CacheManager. This will make things easier when we change 
something about the cache mechanism later.

You're right about the ResolveTest: it should probably use the CacheManager to 
retrieve the filename instead of construct the name itself.
I'll modify this when I have some time.

regards,
Maarten


----- Original Message ----
From: Xavier Hanin (JIRA) <[EMAIL PROTECTED]>
To: [email protected]
Sent: Thursday, March 8, 2007 8:52:24 AM
Subject: [jira] Commented: (IVY-366) Scope and status leakage during build 
lifecycle


    [ 
https://issues.apache.org/jira/browse/IVY-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479255
 ] 

Xavier Hanin commented on IVY-366:
----------------------------------

Good work Maarten! I've just fixed a little issue in IvyTask (a forgotten 
replacement of MessageImpl used, and a missing parameter in one ensureResolved 
method.

One thing I'd like to discuss: why remove XmlReportOutputter.getReportFileName? 
Changing the signature to take a resolveId would have been better, no? Because 
now you have some piece of code (like ResolveTest) which constructs the file 
name themselves.







 
____________________________________________________________________________________
Expecting? Get great news right away with email Auto-Check. 
Try the Yahoo! Mail Beta.
http://advision.webevents.yahoo.com/mailbeta/newmail_tools.html

Reply via email to