On 6/27/07, Gilles Scokart <[EMAIL PROTECTED]> wrote:
> public UnmodifiableExtendableItem(Map stdAttributes, Map
extraAttributes) {
> if (stdAttributes != null) {
> - _attributes.putAll(stdAttributes);
> - _stdAttributes.putAll(stdAttributes);
> + attributes.putAll(stdAttributes);
> + stdAttributes.putAll(stdAttributes);
> }
> if (extraAttributes != null) {
> - _attributes.putAll(extraAttributes);
> - _extraAttributes.putAll(extraAttributes);
> + attributes.putAll(extraAttributes);
> + extraAttributes.putAll(extraAttributes);
> }
> }
>
The gump failure comes from this : extraAttributes.putAll
(extraAttributes).
Indeed. I've checked in fix, for this and another problem in IvyBuildNumber
Tips in eclipse: use the refactoring "rename" (Alt+Shit+R) instead of
the rename in files (Ctrl+Shift+1). The 'refactoring' rename check
that the new name is not already used, while the 'rename in files'
doesn't. (Unfortunately, it is a little bit slower)
I already use refactor rename, but apply it despite problems and fix
problems after. And sometimes I forget some problems... Fortunately we have
unit tests, but it's not the safest way to do, I might introduce problems in
untested code. But this refactoring is already so painful that I don't know
if I'll have enough time, energy and motivation to do it much more
carefully. OTOH the earlier we do it, and the more real world tests we will
have.
Xavier
--
Gilles SCOKART
--
Xavier Hanin - Independent Java Consultant
Manage your dependencies with Ivy!
http://incubator.apache.org/ivy/
