On 10/29/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
>
> >+ private static List getExtraClasspathFileList(CommandLine line) {
>
> no javadoc?
You're right, I should add some. The fact is that this commit comes from a
patch where there wasn't this method (its code was in the main method), but
the main method length then exceeded checkstyle threshold, thus I run
refactor extract method just to make checkstyle happy, and forgot to add the
javadoc.
>+ while (tokenizer.hasMoreTokens()) {
> >+ } else {
> >+ Message.warn("The extra classpath '"
> >+ file + "' does not exist.");
> >+ }
>
>
> I would add a note what you do with that file. Something like
>
> Message.warn("Skipping extra classpath '" + file + "' as it does not
> exist.");
Good point, will do.
Xavier
Jan
>
--
Xavier Hanin - Independent Java Consultant
http://xhab.blogspot.com/
http://ant.apache.org/ivy/
http://www.xoocode.org/
