An incomplete fix for the NPE bugs in XSAttributeUseImpl.java
-------------------------------------------------------------
Key: XERCESJ-1553
URL: https://issues.apache.org/jira/browse/XERCESJ-1553
Project: Xerces2-J
Issue Type: Bug
Components: Other
Reporter: Guangtai Liang
Priority: Critical
The fix revision 320528 was aimed to remove an NPE bug on the "this.fDefault"
and "this.fDefault.actualValue" in the method "getConstraintValue" of the file
"/xerces/java/trunk/src/org/apache/xerces/impl/xs/XSAttributeUseImpl.java" ,
but it is incomplete.
Since the "this.fDefault" is a class field and also could be null during the
run-time execution, it should also be null-checked before being dereferenced in
other methods.
The buggy code locations the same fix needs to be applied at are as bellows:
Line 123 of the method "getActualVC";
public Object getActualVC() {
return getConstraintType() == XSConstants.VC_NONE ?
null :
fDefault.actualValue;
}
Line 129 of the method "getActualVCType":
public short getActualVCType() {
return getConstraintType() == XSConstants.VC_NONE ?
XSConstants.UNAVAILABLE_DT :
fDefault.actualValueType;
}
Line 135 of the method "getItemValueTypes" :
public ShortList getItemValueTypes() {
return getConstraintType() == XSConstants.VC_NONE ?
null :
fDefault.itemValueTypes;
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
