mbeckerle commented on code in PR #7:
URL: https://github.com/apache/xerces-j/pull/7#discussion_r1962454261
##########
src/org/apache/xerces/impl/XML11NSDocumentScannerImpl.java:
##########
@@ -130,6 +132,20 @@ protected boolean scanStartElement() throws IOException,
XNIException {
// Note: namespace processing is on by default
fEntityScanner.scanQName(fElementQName);
+
Review Comment:
There is almost the same code in this class and in the
XMLDocumentFragmentScanner.
I hate duplicating code.
Is it needed in both places if it is to work with XML 1.0 and XML 1.1 ? Is
there a sensible place to factor it out?
##########
tests/loc/XercesDOMLocationTest.java:
##########
@@ -0,0 +1,91 @@
+package loc;
+
+import org.apache.xerces.parsers.DOMParser;
+import org.apache.xerces.dom.DOMLocatorImpl;
+import junit.framework.*;
+
+import static
org.apache.xerces.parsers.XML11Configuration.LOCATION_INFO_FEATURE;
+import org.w3c.dom.*;
+
+import java.io.File;
+
+public class XercesDOMLocationTest extends TestCase {
Review Comment:
Need tests for XML 1.1 as well as XML 1.0.
##########
src/org/apache/xerces/dom/NodeImpl.java:
##########
@@ -145,6 +146,8 @@ public abstract class NodeImpl
// Data
//
+ public Locator locator;
Review Comment:
Revert. This change not needed. This file needs no modification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
