SingingBush commented on PR #28: URL: https://github.com/apache/xerces-j/pull/28#issuecomment-3419587231
I've rebased and pushed. One thing to note, in this PR I closed `p` tags. For Javadoc this isn't actually needed and whether or not `</p>` is used varies depending on code style in the project. It certainly doesn't do any harm. Personally I prefer to close them as I've been used to strict xhtml in the past but some people prefer only to use the opening `<p>` in Javadocs. I don't mind removing them if you'd prefer. Also, this PR doesn't fix all Javadoc errors. There's a huge amount of errors and warnings. Especially around invalid tags. Errors like `error: attribute not supported in HTML5` and a lot of warning for missing `@return` (`warning: no @return`). I'm happy to keep going with fixing more of these in another PR but it would be good to get #23 merged first and ensure docs are built during CI. I'd recommend also, once the errors are fixed, failing builds if the Javadoc is invalid. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
