elharo commented on code in PR #39:
URL: https://github.com/apache/xerces-j/pull/39#discussion_r2466363088
##########
src/org/apache/xml/serialize/BaseMarkupSerializer.java:
##########
@@ -1842,7 +1847,12 @@ protected DOMError modifyDOMError(String message, short
severity, String type, N
}
-
+ /**
+ * Should be used by subclasses of BaseMarkupSerializer when a fatal
problem occurs.
Review Comment:
used --> called
##########
src/org/apache/xml/serialize/OutputFormat.java:
##########
@@ -486,14 +488,18 @@ public EncodingInfo getEncodingInfo() throws
UnsupportedEncodingException {
}
/**
- * Sets whether java encoding names are permitted
+ * Sets whether java encoding names are permitted.
+ *
+ * @param allow set to true to permit java encoding names
*/
public void setAllowJavaNames (boolean allow) {
_allowJavaNames = allow;
}
/**
- * Returns whether java encoding names are permitted
+ * Returns whether java encoding names are permitted.
+ *
+ * @return whether java encoding names are permitted
Review Comment:
java --> Java
##########
src/org/apache/xml/serialize/OutputFormat.java:
##########
@@ -486,14 +488,18 @@ public EncodingInfo getEncodingInfo() throws
UnsupportedEncodingException {
}
/**
- * Sets whether java encoding names are permitted
+ * Sets whether java encoding names are permitted.
+ *
+ * @param allow set to true to permit java encoding names
Review Comment:
java --> Java
##########
src/org/apache/xml/serialize/SerializerFactory.java:
##########
@@ -132,8 +151,10 @@ public abstract Serializer makeSerializer( Writer writer,
* using the output byte stream and the encoding specified in the
* output format.
*
- * @throws UnsupportedEncodingException The specified encoding is
- * not supported
+ * @param output an output byte stream that will be written to
Review Comment:
an output byte stream --> an output stream
##########
src/org/apache/xml/serialize/OutputFormat.java:
##########
@@ -388,6 +388,8 @@ public int getIndent()
/**
* Returns true if indentation was specified.
+ *
+ * @return rue if indentation was specified
Review Comment:
true
##########
src/org/apache/xml/serialize/OutputFormat.java:
##########
@@ -486,14 +488,18 @@ public EncodingInfo getEncodingInfo() throws
UnsupportedEncodingException {
}
/**
- * Sets whether java encoding names are permitted
+ * Sets whether java encoding names are permitted.
Review Comment:
java --> Java
##########
src/org/apache/xml/serialize/OutputFormat.java:
##########
@@ -486,14 +488,18 @@ public EncodingInfo getEncodingInfo() throws
UnsupportedEncodingException {
}
/**
- * Sets whether java encoding names are permitted
+ * Sets whether java encoding names are permitted.
+ *
+ * @param allow set to true to permit java encoding names
*/
public void setAllowJavaNames (boolean allow) {
_allowJavaNames = allow;
}
/**
- * Returns whether java encoding names are permitted
+ * Returns whether java encoding names are permitted.
Review Comment:
java --> Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
