elharo commented on code in PR #57:
URL: https://github.com/apache/xerces-j/pull/57#discussion_r2542015700
##########
src/org/apache/xerces/impl/dv/xs/AbstractDateTimeDV.java:
##########
@@ -221,12 +220,13 @@ protected short compareOrder(DateTimeData date1,
DateTimeData date2) {
}
/**
- * Parses time hh:mm:ss.sss and time zone if any
+ * Parses time hh:mm:ss.sss and time zone if any.
*
- * @param start
- * @param end
- * @param data
- * @exception RuntimeException
+ * @param buffer a string in which a time value exists in the format
<code>hh:mm:ss.sss</code>
+ * @param start the start position
+ * @param end the end position
+ * @param data a DateTimeData that will contain the output of parsing
the string
Review Comment:
a DateTimeData that will contain the output of parsing the string --> the
output from parsing the string
##########
src/org/apache/xerces/impl/dv/xs/AbstractDateTimeDV.java:
##########
@@ -221,12 +220,13 @@ protected short compareOrder(DateTimeData date1,
DateTimeData date2) {
}
/**
- * Parses time hh:mm:ss.sss and time zone if any
+ * Parses time hh:mm:ss.sss and time zone if any.
*
- * @param start
- * @param end
- * @param data
- * @exception RuntimeException
+ * @param buffer a string in which a time value exists in the format
<code>hh:mm:ss.sss</code>
Review Comment:
a string in which a time value exists in the format <code>hh:mm:ss.sss</code>
-->
a time in the format <code>hh:mm:ss.sss</code>
##########
src/org/apache/xerces/impl/dv/xs/AbstractDateTimeDV.java:
##########
@@ -177,8 +177,7 @@ else if ( date2.utc=='Z' ) {
}
/**
- * Given normalized values, determines order-relation
- * between give date/time objects.
+ * Given normalized values, determines order-relation between give
date/time objects.
Review Comment:
give --> given
or just delete it
##########
src/org/apache/xerces/impl/dv/xs/AbstractDateTimeDV.java:
##########
@@ -266,11 +266,11 @@ protected void getTime (String buffer, int start, int
end, DateTimeData data) t
/**
* Parses date CCYY-MM-DD
*
- * @param buffer
+ * @param buffer a string in which a date value exists in the format
<code>CCYY-MM-DD</code>
* @param start start position
* @param end end position
- * @param date
- * @exception RuntimeException
+ * @param date a DateTimeData that will contain the output of parsing
the string
Review Comment:
the output from parsing the string
##########
src/org/apache/xerces/impl/dv/xs/AbstractDateTimeDV.java:
##########
@@ -345,9 +347,11 @@ protected void parseTimeZone (String buffer, int start,
int end, DateTimeData da
/**
* Parses time zone: 'Z' or {+,-} followed by hh:mm
*
- * @param data
- * @param sign
- * @exception RuntimeException
+ * @param buffer a string in which a TimeZone value exists
+ * @param data a DateTimeData that will contain the output of parsing
the string
Review Comment:
the output from parsing the string
##########
src/org/apache/xerces/impl/dv/xs/AbstractDateTimeDV.java:
##########
@@ -266,11 +266,11 @@ protected void getTime (String buffer, int start, int
end, DateTimeData data) t
/**
* Parses date CCYY-MM-DD
*
- * @param buffer
+ * @param buffer a string in which a date value exists in the format
<code>CCYY-MM-DD</code>
Review Comment:
a date in the format <code>CCYY-MM-DD</code>
##########
src/org/apache/xerces/impl/dv/xs/AbstractDateTimeDV.java:
##########
@@ -324,9 +324,11 @@ else if (length > 4 && buffer.charAt(start)=='0'){
* Shared code from Date and YearMonth datatypes.
* Finds if time zone sign is present
*
- * @param end
- * @param date
- * @exception RuntimeException
+ * @param buffer a string in which a TimeZone value exists
+ * @param start start position
+ * @param end end position
+ * @param date a DateTimeData that will contain the output of parsing
the string
Review Comment:
the output from parsing the string
##########
src/org/apache/xerces/impl/dv/xs/AbstractDateTimeDV.java:
##########
@@ -285,13 +285,13 @@ protected int getDate (String buffer, int start, int end,
DateTimeData date) thr
}
/**
- * Parses date CCYY-MM
+ * Parses date CCYY-MM.
*
- * @param buffer
+ * @param buffer a string in which a Year/Month value exists in the
format <code>CCYY-MM</code>
* @param start start position
* @param end end position
- * @param date
- * @exception RuntimeException
+ * @param date a DateTimeData that will contain the output of parsing
the string
Review Comment:
the output from parsing the string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
