elharo commented on code in PR #64:
URL: https://github.com/apache/xerces-j/pull/64#discussion_r2557396127
##########
src/org/apache/html/dom/HTMLDocumentImpl.java:
##########
@@ -614,23 +650,35 @@ public void close()
}
}
-
+ /**
+ * Write a string.
+ * <p>Not supported</p>
+ *
+ * @param text a string to write
+ */
+ @Override
public void write( String text )
{
// Write a string into the in-memory writer.
if ( _writer != null )
_writer.write( text );
}
-
+ /**
+ * Write a line into the in-memory writer.
Review Comment:
don't mention the in-memory writer. Just say this method has no effect.
##########
src/org/apache/html/dom/HTMLDocumentImpl.java:
##########
@@ -614,23 +650,35 @@ public void close()
}
}
-
+ /**
+ * Write a string.
+ * <p>Not supported</p>
Review Comment:
Instead of Not supported I might say "This is a no-op in this class." or
something like that.
##########
src/org/apache/html/dom/HTMLDocumentImpl.java:
##########
@@ -595,7 +625,10 @@ public HTMLCollection getAnchors()
return _anchors;
}
-
+ /**
+ * Not supported
Review Comment:
Instead of Not supported I might say "This is a no-op in this class." or
something like that to avoid the expectation that this throws
UnsupportedOperationException
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]