elharo commented on code in PR #65:
URL: https://github.com/apache/xerces-j/pull/65#discussion_r2558050027
##########
build.xml:
##########
@@ -535,7 +539,11 @@ Authors:
doctitle='Xerces Native Interface'
bottom='${copyright}'
additionalparam='-quiet ${additional.param}'
- />
+ failonerror='yes'
+ failonwarning='yes'
Review Comment:
No. I do not want the build to fail on a warning. I'm not sure it should
fail on an error here, but definitely not on a warning
##########
src/org/apache/xerces/impl/xpath/regex/REUtil.java:
##########
@@ -218,7 +218,7 @@ else if (next == '^' && offset + 1 < len) {
/**
* Sample entry.
- * <div>Usage: <KBD>org.apache.xerces.utils.regex.REUtil <regex>
<string></KBD></div>
+ * <p>Usage: <code>org.apache.xerces.utils.regex.REUtil <regex>
<string></code></p>
Review Comment:
should probably be samp instead of code if I recall correctly
##########
build.xml:
##########
@@ -575,7 +591,11 @@ Authors:
windowtitle='Other Classes' doctitle='Other Classes'
bottom='${copyright}'
additionalparam='-quiet ${additional.param}'
- />
+ failonerror='yes'
+ failonwarning='yes'
Review Comment:
revert
##########
build.xml:
##########
@@ -545,7 +553,11 @@ Authors:
doctitle='XML Schema API'
bottom='${copyright}'
additionalparam='-quiet ${additional.param}'
- />
+ failonerror='yes'
+ failonwarning='yes'
Review Comment:
revert
##########
build.xml:
##########
@@ -92,8 +92,8 @@ Authors:
<property name="optimize" value="on"/>
<property name="deprecation" value="off"/>
- <property name="javac.source" value="1.8"/>
- <property name="javac.target" value="1.8"/>
+ <property name="javac.source" value="1.7"/>
Review Comment:
see https://github.com/apache/xerces-j/pull/60
let's keep different issues in different PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
