elharo commented on code in PR #73:
URL: https://github.com/apache/xerces-j/pull/73#discussion_r2578379291
##########
src/org/apache/xerces/impl/dv/xs/TypeValidator.java:
##########
@@ -48,19 +49,41 @@ public Object run() {
return Boolean.FALSE;
}}) == Boolean.TRUE;
- // which facets are allowed for this type
+ /**
+ * Which facets are allowed for this type.
+ * <p><em>Note</em>: {@link org.apache.xerces.xs.XSSimpleTypeDefinition}
defines constants for various facets</p>
Review Comment:
period
I might delete "Note"
##########
src/org/apache/xerces/impl/dv/xs/TypeValidator.java:
##########
@@ -48,19 +49,41 @@ public Object run() {
return Boolean.FALSE;
}}) == Boolean.TRUE;
- // which facets are allowed for this type
+ /**
+ * Which facets are allowed for this type.
+ * <p><em>Note</em>: {@link org.apache.xerces.xs.XSSimpleTypeDefinition}
defines constants for various facets</p>
+ *
+ * @return a bit-combination of allowed facets
+ *
+ * @see org.apache.xerces.xs.XSSimpleTypeDefinition
+ */
public abstract short getAllowedFacets();
- // convert a string to an actual value. for example,
- // for number types (decimal, double, float, and types derived from them),
- // get the BigDecimal, Double, Flout object.
- // for some types (string and derived), they just return the string itself
+ /**
+ * Converts a string to an actual value.
+ * <p>for example: for number types (decimal, double, float, and types
derived from them),
Review Comment:
For
##########
src/org/apache/xerces/impl/dv/xs/TypeValidator.java:
##########
@@ -133,13 +187,24 @@ private int getCodePointLength(String value) {
return len - surrogatePairCount;
}
- // check whether the character is in the range 0x30 ~ 0x39
+ /**
+ * Check whether the char is a digit or not
+ * <p>check whether the character is in the range <code>0x30 ~
0x39</code></p>
+ *
+ * @param ch the char value to check
+ * @return true if the char is a digit
Review Comment:
an ASCII digit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
