elharo commented on code in PR #72:
URL: https://github.com/apache/xerces-j/pull/72#discussion_r2578388162
##########
src/org/apache/xerces/parsers/AbstractDOMParser.java:
##########
@@ -285,7 +295,12 @@ public Throwable fillInStackTrace() {
// Constructors
//
- /** Default constructor. */
+ /**
+ * Default constructor.
+ * <p>Constructs a DOM parser using default features</p>
Review Comment:
period
##########
src/org/apache/xerces/parsers/AbstractDOMParser.java:
##########
@@ -1901,19 +1924,17 @@ public void endExternalSubset (Augmentations augs)
throws XNIException {
/**
* An internal entity declaration.
*
- * @param name The name of the entity. Parameter entity names start with
- * '%', whereas the name of a general entity is just the
- * entity name.
- * @param text The value of the entity.
- * @param nonNormalizedText The non-normalized value of the entity. This
- * value contains the same sequence of characters that was in
- * the internal entity declaration, without any entity
- * references expanded.
- * @param augs Additional information that may include infoset
- * augmentations.
- *
- * @throws XNIException Thrown by handler to signal an error.
+ * @param name the name of the entity. Parameter entity names start with
'%', whereas
+ * the name of a general entity is just the entity name
Review Comment:
needs a period since this ends a sentence
##########
src/org/apache/xerces/parsers/AbstractDOMParser.java:
##########
@@ -1901,19 +1924,17 @@ public void endExternalSubset (Augmentations augs)
throws XNIException {
/**
* An internal entity declaration.
*
- * @param name The name of the entity. Parameter entity names start with
- * '%', whereas the name of a general entity is just the
- * entity name.
- * @param text The value of the entity.
- * @param nonNormalizedText The non-normalized value of the entity. This
- * value contains the same sequence of characters that was in
- * the internal entity declaration, without any entity
- * references expanded.
- * @param augs Additional information that may include infoset
- * augmentations.
- *
- * @throws XNIException Thrown by handler to signal an error.
+ * @param name the name of the entity. Parameter entity names start with
'%', whereas
+ * the name of a general entity is just the entity name
+ * @param text the value of the entity
+ * @param nonNormalizedText The non-normalized value of the entity. This
value contains
+ * the same sequence of characters that was in the internal
entity declaration,
+ * without any entity references expanded
Review Comment:
period
##########
src/org/apache/xerces/parsers/AbstractDOMParser.java:
##########
@@ -466,17 +487,16 @@ public void setLocale (Locale locale) {
* <strong>Note:</strong> This method is not called for entity references
* appearing as part of attribute values.
*
- * @param name The name of the general entity.
- * @param identifier The resource identifier.
- * @param encoding The auto-detected IANA encoding name of the entity
- * stream. This value will be null in those situations
- * where the entity encoding is not auto-detected (e.g.
- * internal entities or a document entity that is
- * parsed from a java.io.Reader).
- * @param augs Additional information that may include infoset
augmentations
+ * @param name the name of the entity
Review Comment:
general entity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
