lyca commented on code in PR #96:
URL: https://github.com/apache/xerces-j/pull/96#discussion_r3922691262
##########
tests/dom/dom3/Test.java:
##########
@@ -43,643 +44,371 @@
import org.w3c.dom.ls.LSResourceResolver;
import org.w3c.dom.ls.LSSerializer;
-import dom.util.Assertion;
+public class Test extends TestCase implements DOMErrorHandler,
LSResourceResolver {
-/**
- * The program tests vacarious DOM Level 3 functionality
- *
- * @version $Id$
- */
-public class Test implements DOMErrorHandler, LSResourceResolver {
-
- static int errorCounter = 0;
- static DOMErrorHandler errorHandler = new Test();
- static LSResourceResolver resolver = new Test();
-
- public static void main( String[] argv) {
- try {
- boolean namespaces = true;
- System.out.println("Running dom.dom3.Test...");
-
System.setProperty(DOMImplementationRegistry.PROPERTY,"org.apache.xerces.dom.DOMImplementationSourceImpl
org.apache.xerces.dom.DOMXSImplementationSourceImpl");
-
-
- DOMImplementationLS impl =
(DOMImplementationLS)DOMImplementationRegistry.newInstance().getDOMImplementation("LS");
-
- Assertion.verify(impl!=null, "domImplementation != null");
-
- LSParser builder =
impl.createLSParser(DOMImplementationLS.MODE_SYNCHRONOUS,
- null);
-
- LSSerializer writer = impl.createLSSerializer();
- DOMConfiguration config = writer.getDomConfig();
-
config.setParameter("namespaces",(namespaces)?Boolean.TRUE:Boolean.FALSE);
- config.setParameter("validate",Boolean.FALSE);
-
- //----------------------------
- // TEST: lookupPrefix
- // isDefaultNamespace
- // lookupNamespaceURI
- //----------------------------
- //System.out.println("TEST #1: lookupPrefix, isDefaultNamespace,
lookupNamespaceURI, input: tests/dom/dom3/input.xml");
- {
-
- Document doc = builder.parseURI("tests/dom/dom3/input.xml");
- NodeList ls = doc.getElementsByTagName("a:elem_a");
-
- NodeImpl elem = (NodeImpl)ls.item(0);
- if (namespaces) {
-
//System.out.println("[a:elem_a].lookupPrefix('http://www.example.com', true)
== null");
-
Assertion.verify(elem.lookupPrefix("http://www.example.com";).equals("ns1"),
-
"[a:elem_a].lookupPrefix(http://www.example.com)==null");
-
-
-
//System.out.println("[a:elem_a].isDefaultNamespace('http://www.example.com')
== true");
-
Assertion.verify(elem.isDefaultNamespace("http://www.example.com";) == true,
-
"[a:elem_a].isDefaultNamespace(http://www.example.com)==true");
-
-
-
//System.out.println("[a:elem_a].lookupPrefix('http://www.example.com', false)
== ns1");
-
Assertion.verify(elem.lookupPrefix("http://www.example.com";).equals("ns1"),
-
"[a:elem_a].lookupPrefix(http://www.example.com)==ns1");
-
-
-
Assertion.verify(elem.lookupNamespaceURI("xsi").equals("http://www.w3.org/2001/XMLSchema-instance";),
- "[a:elem_a].lookupNamespaceURI('xsi') ==
'http://www.w3.org/2001/XMLSchema-instance'" );
-
- } else {
- Assertion.verify(
elem.lookupPrefix("http://www.example.com";) ==
null,"lookupPrefix(http://www.example.com)==null");
- }
-
- ls = doc.getElementsByTagName("bar:leaf");
- elem = (NodeImpl)ls.item(0);
- Assertion.verify(elem.lookupPrefix("url1:").equals("foo"),
- "[bar:leaf].lookupPrefix('url1:', false) ==
foo");
- //System.out.println("[bar:leaf].lookupPrefix('url1:', false)
== "+ );
-
- //System.out.println("==>Create b:baz with namespace 'b:' and
xmlns:x='b:'");
- ls = doc.getElementsByTagName("baz");
- elem = (NodeImpl)ls.item(0);
- ls = doc.getElementsByTagName("elem8");
- elem = (NodeImpl)ls.item(0);
- Element e1 = doc.createElementNS("b:","p:baz");
- e1.setAttributeNS("http://www.w3.org/2000/xmlns/";, "xmlns:x",
"b:");
- elem.appendChild(e1);
-
-
-
Assertion.verify(((NodeImpl)e1).lookupPrefix("b:").equals("p"),
- "[p:baz].lookupPrefix('b:', false) == p");
-
-
-
- //System.out.println("[p:baz].lookupPrefix('b:', false) == "+
((NodeImpl)e1).lookupPrefix("b:",false));
-
-
Assertion.verify(elem.lookupNamespaceURI("xsi").equals("http://www.w3.org/2001/XMLSchema-instance";),
- "[bar:leaf].lookupNamespaceURI('xsi') ==
'http://www.w3.org/2001/XMLSchema-instance'" );
-
-
- }
-
- //************************
- //* Test normalizeDocument()
- //************************
- //System.out.println("TEST #2: normalizeDocumention() - 3 errors,
input: tests/dom/dom3/schema.xml");
- {
- errorCounter = 0;
- config = builder.getDomConfig();
- config.setParameter("error-handler",errorHandler);
- config.setParameter("validate", Boolean.TRUE);
- Document core = builder.parseURI("tests/dom/dom3/schema.xml");
- Assertion.verify(errorCounter == 0, "No errors should be
reported");
-
- errorCounter = 0;
- NodeList ls2 = core.getElementsByTagName("decVal");
- Element testElem = (Element)ls2.item(0);
- testElem.removeAttributeNS("http://www.w3.org/2000/xmlns/";,
"xmlns");
-
- ls2 = core.getElementsByTagName("v02:decVal");
- testElem = (Element)ls2.item(0);
- testElem.setPrefix("myPrefix");
- Element root = core.getDocumentElement();
-
- Element newElem = core.createElementNS(null, "decVal");
- String data="4.5";
- if (true) {
- data = "string";
- }
- newElem.appendChild(core.createTextNode(data));
- root.insertBefore(newElem, testElem);
-
- newElem = core.createElementNS(null, "notInSchema");
- newElem.appendChild(core.createTextNode("added new element"));
- root.insertBefore(newElem, testElem);
-
- root.appendChild(core.createElementNS("UndefinedNamespace",
"NS1:foo"));
- config = core.getDomConfig();
- config.setParameter("error-handler",errorHandler);
- config.setParameter("validate", Boolean.TRUE);
- config.setParameter("schema-type",
"http://www.w3.org/2001/XMLSchema";);
- core.normalizeDocument();
- Assertion.verify(errorCounter == 3, "3 errors should be
reported");
-
- errorCounter = 0;
- config.setParameter("validate", Boolean.FALSE);
- config.setParameter("comments", Boolean.FALSE);
- core.normalizeDocument();
- Assertion.verify(errorCounter == 0, "No errors should be
reported");
-
-
- config = builder.getDomConfig();
- config.setParameter("validate", Boolean.FALSE);
-
- }
-
-
- //************************
- //* Test normalizeDocument()
- //************************
- // System.out.println("TEST #3: normalizeDocumention() + psvi,
input: data/personal-schema.xml");
- {
- errorCounter = 0;
- config = builder.getDomConfig();
- config.setParameter("error-handler",errorHandler);
- config.setParameter("validate", Boolean.TRUE);
- config.setParameter("psvi", Boolean.TRUE);
- Document core = builder.parseURI("data/personal-schema.xml");
- Assertion.verify(errorCounter == 0, "No errors should be
reported");
-
- NodeList ls2 = core.getElementsByTagName("person");
-
- Element testElem = (Element)ls2.item(0);
-
Assertion.verify(((ElementPSVI)testElem).getElementDeclaration().getName().equals("person"),
"testElem decl");
- Element e1 = core.createElementNS(null, "person");
-
- core.getDocumentElement().appendChild(e1);
- e1.setAttributeNS(null, "id", "newEmp");
- Element e2 = core.createElementNS(null, "name");
- e2.appendChild(core.createElementNS(null, "family"));
- e2.appendChild(core.createElementNS(null, "given"));
- e1.appendChild(e2);
- e1.appendChild(core.createElementNS(null, "email"));
- Element e3 = core.createElementNS(null, "link");
- e3.setAttributeNS(null, "manager", "Big.Boss");
- e1.appendChild(e3);
-
- testElem.removeAttributeNode(testElem.getAttributeNodeNS(null,
"contr"));
- NamedNodeMap map = testElem.getAttributes();
- config = core.getDomConfig();
- errorCounter = 0;
- config.setParameter("psvi", Boolean.TRUE);
- config.setParameter("error-handler",errorHandler);
- config.setParameter("validate", Boolean.TRUE);
- config.setParameter("schema-type",
"http://www.w3.org/2001/XMLSchema";);
- core.normalizeDocument();
- Assertion.verify(errorCounter == 0, "No errors should be
reported");
-
Assertion.verify(((ElementPSVI)e1).getElementDeclaration().getName().equals("person"),
"e1 decl");
-
- config = builder.getDomConfig();
- config.setParameter("validate", Boolean.FALSE);
-
-
- }
-
- //************************
- //* Test normalizeDocument(): core tests
- //************************
- // System.out.println("TEST #4: normalizeDocument() core");
- {
-
- // check that namespace normalization algorithm works correctly
- Document doc= new DocumentImpl();
- Element root =
doc.createElementNS("http://www.w3.org/1999/XSL/Transform";, "xsl:stylesheet");
- doc.appendChild(root);
- root.setAttributeNS("http://attr1";, "xsl:attr1","");
-
- Element child1 = doc.createElementNS("http://child1";,
"NS2:child1");
- child1.setAttributeNS("http://attr2";, "NS2:attr2","");
- root.appendChild(child1);
-
- Element child2 =
doc.createElementNS("http://child2","NS4:child2";);
- child2.setAttributeNS("http://attr3","attr3";, "");
- root.appendChild(child2);
-
- Element child3 =
doc.createElementNS("http://www.w3.org/1999/XSL/Transform","xsl:child3";);
- child3.setAttributeNS("http://a1","attr1";, "");
- child3.setAttributeNS("http://a2","xsl:attr2";, "");
- child3.setAttributeNS("http://www.w3.org/2000/xmlns/";,
"xmlns:a1", "http://a1";);
- child3.setAttributeNS("http://www.w3.org/2000/xmlns/";,
"xmlns:xsl", "http://a2";);
-
- Element child4 = doc.createElementNS(null, "child4");
- child4.setAttributeNS("http://a1";, "xsl:attr1", "");
- child4.setAttributeNS("http://www.w3.org/2000/xmlns/";,
"xmlns", "default");
- child3.appendChild(child4);
- root.appendChild(child3);
-
- doc.normalizeDocument();
-
- //
- // assertions
- //
-
- // xsl:stylesheet should include 2 namespace declarations
- String name = root.getNodeName();
- Assertion.verify(name.equals("xsl:stylesheet"),
"xsl:stylesheet");
-
- String value =
root.getAttributeNS("http://www.w3.org/2000/xmlns/";, "xsl");
- Assertion.verify(value!=null, "xmlns:xsl != null");
-
Assertion.verify(value.equals("http://www.w3.org/1999/XSL/Transform";),
"xmlns:xsl="+value);
-
- value = root.getAttributeNS("http://www.w3.org/2000/xmlns/";,
"NS1");
-
- Assertion.verify(value!=null &&
- value.equals("http://attr1";),
"xmlns:NS1="+value);
-
- // child includes 2 namespace decls
-
- Assertion.verify(child1.getNodeName().equals("NS2:child1"),
"NS2:child1");
- value = child1.getAttributeNS("http://www.w3.org/2000/xmlns/";,
"NS2");
- Assertion.verify(value!=null &&
- value.equals("http://child1";),
"xmlns:NS2="+value);
-
- value = child1.getAttributeNS("http://www.w3.org/2000/xmlns/";,
"NS1");
- Assertion.verify(value!=null &&
- value.equals("http://attr2";),
"xmlns:NS1="+value);
-
-
- // child3
-
-
- Assertion.verify(child3.getNodeName().equals("xsl:child3"),
"xsl:child3");
- value = child3.getAttributeNS("http://www.w3.org/2000/xmlns/";,
"NS1");
- Assertion.verify(value!=null &&
- value.equals("http://a2";),
"xmlns:NS1="+value);
-
-
- value = child3.getAttributeNS("http://www.w3.org/2000/xmlns/";,
"a1");
- Assertion.verify(value!=null &&
- value.equals("http://a1";), "xmlns:a1="+value);
-
-
- value = child3.getAttributeNS("http://www.w3.org/2000/xmlns/";,
"xsl");
- Assertion.verify(value!=null &&
-
value.equals("http://www.w3.org/1999/XSL/Transform";), "xmlns:xsl="+value);
-
-
- Attr attr = child3.getAttributeNodeNS("http://a2";, "attr2");
- Assertion.verify(attr != null, "NS1:attr2 !=null");
-
- Assertion.verify(child3.getAttributes().getLength() == 5,
"xsl:child3 has 5 attrs");
-
- // child 4
- Attr temp =
child4.getAttributeNodeNS("http://www.w3.org/2000/xmlns/";, "xmlns");
- Assertion.verify(temp.getNodeName().equals("xmlns"),
"attribute name is xmlns");
- Assertion.verify(temp.getNodeValue().length() == 0,
"xmlns=''");
- /*
- OutputFormat format = new OutputFormat((Document)doc);
- format.setLineSeparator(LineSeparator.Windows);
- format.setIndenting(true);
- format.setLineWidth(0);
- format.setPreserveSpace(true);
- XMLSerializer serializer = new XMLSerializer(System.out,
format);
- serializer.serialize(doc);
- */
-
- }
-
-
- //************************
- //* Test normalizeDocument(): core tests
- //************************
- //System.out.println("TEST #4: namespace fixup during
serialization");
- {
-
- Document doc= new DocumentImpl();
- Element root =
doc.createElementNS("http://www.w3.org/1999/XSL/Transform";, "xsl:stylesheet");
- doc.appendChild(root);
- root.setAttributeNS("http://attr1";, "xsl:attr1","");
-
- Element child1 = doc.createElementNS("http://child1";,
"NS2:child1");
- child1.setAttributeNS("http://attr2";, "NS2:attr2","");
- root.appendChild(child1);
-
- Element child2 =
doc.createElementNS("http://child2","NS4:child2";);
- child2.setAttributeNS("http://attr3","attr3";, "");
- root.appendChild(child2);
-
- Element child3 =
doc.createElementNS("http://www.w3.org/1999/XSL/Transform","xsl:child3";);
- child3.setAttributeNS("http://a1","attr1";, "");
- child3.setAttributeNS("http://a2","xsl:attr2";, "");
- child3.setAttributeNS("http://www.w3.org/2000/xmlns/";,
"xmlns:a1", "http://a1";);
- child3.setAttributeNS("http://www.w3.org/2000/xmlns/";,
"xmlns:xsl", "http://a2";);
-
- Element child4 = doc.createElementNS(null, "child4");
- child4.setAttributeNS("http://a1";, "xsl:attr1", "");
- child4.setAttributeNS("http://www.w3.org/2000/xmlns/";,
"xmlns", "default");
-
- child3.appendChild(child4);
- root.appendChild(child3);
-
-
- // serialize data
- writer.getDomConfig().setParameter("namespaces", Boolean.TRUE);
- String xmlData = writer.writeToString(doc);
- Reader r = new StringReader(xmlData);
- LSInput in = impl.createLSInput();
- in.setCharacterStream(r);
- doc = builder.parse(in);
-
- //
- // make sure algorithm works correctly
- //
-
- root = doc.getDocumentElement();
- child1 = (Element)root.getFirstChild();
- child2 = (Element)child1.getNextSibling();
- child3 = (Element)child2.getNextSibling();
+ private int errorCounter;
+ private DOMImplementationLS impl;
+ private LSParser builder;
+ protected void setUp() throws Exception {
+ super.setUp();
+ System.setProperty(DOMImplementationRegistry.PROPERTY,
Review Comment:
I just had another look at this. Setting DOMImplementationRegistry.PROPERTY
shouldn't be necessary in the tests at all nowadays. The correct fallback is
already provided natively via the ServiceLoader pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
