Hi Maxim,

yes, you are right. in case that prop is multi-valued the test case would throw an exception, which is not correct.

I've fixed the test case and also the other XXXPropertyTest classes, which retrieved the second value the same way.
svn revision: 164194


Thanks, for identifying this issue.

regards
 marcel

Maxim wrote:
Hello jackrabbit-dev.

In the file:
/jackrabbit/src/test/org/apache/jackrabbit/test/api/BooleanPropertyTest.java

from line 115 it says:
-----------------------------------
    public void testGetStream() throws RepositoryException, IOException {
        Value val = PropertyUtil.getValue(prop);
        BufferedInputStream in = new BufferedInputStream(val.getStream());
        Value otherVal = prop.getValue();
-----------------------------------

While val value is calculated in "multivalue-safe" manner,
the otherVal is not (and this is indeed the same value).

Shouldn't the last line say:
-----------------------------------
        Value otherVal = PropertyUtil.getValue(prop);
-----------------------------------

Thank you.

Reply via email to