Hi Marc, I've already worked on that and just proposed a Pull Request, before reading your reply with suggestions!
So, as I've already proposed the Pull Request at https://github.com/jacoco/jacoco/pull/349 , please forgive me if it does not respect some rule or advice you may have given. I'll check your recommendations this evening, and if I find any mistake I've made, I'll start another pull request. If you check my pull request before I check your recommendations, please give me some direct feedback, it is really appreciated! Thanks, Cristiano Il giorno venerdì 2 ottobre 2015 10:03:36 UTC+2, Marc R. Hoffmann ha scritto: > > Hi Christiano, > > we're happy to accept contributions! For successful review I recommend: > > * Check out existing list of enhancements: > > https://github.com/jacoco/jacoco/issues?q=is%3Aopen+is%3Aissue+label%3Aenhancement > > > For many enhancements possible solutions have already been discussed > > * Use our dev setup: > http://eclemma.org/jacoco/trunk/doc/environment.html > > All formatting and compiler warnings are configured for Eclipse. Also > make sure your contributions comes with tests, we have unit and > integration tests. > > * Create small, independent pull requests at GitHub > > Do not mix several aspects in a single PR. If we do not agree on one > aspect the whole PR will fail to get accepted. > > Regards, > -marc > > On 2015-10-01 15:26, Cristiano Costantini wrote: > > Hi Marc, > > > > I'm trying to implement options for maven plugin report generation => > > https://github.com/cristcost/jacoco > > I really hope you'll consider these developments for inclusion into > > the main project. > > > > If you have any recommendation on code style, quality and approach, > > I'll listen to you carefully! > > > > In the meanwhile I'm trying to reproduce that the Ant Task does. I'm > > not writing any integration test as I'm testing it directly on my > > application. > > > > The idea is to configure it something like this way: > > > > <plugin> > > <groupId>org.jacoco</groupId> > > <artifactId>jacoco-maven-plugin</artifactId> > > <version>0.7.6-SNAPSHOT</version> > > <configuration> > > > > <csvReport>true</csvReport> > > <xmlReport>false</xmlReport> > > <htmlReport>true</htmlReport> > > <includeTests>true</includeTests> > > <artifacts> > > <artifact>net.cristcost.test:module-1</artifact> > > <artifact>net.cristcost.test:module-1</artifact> > > </artifacts> > > </configuration> > > </plugin> > > > > Thank you, > > Cristiano > > > > P.S. Btw congratulations, I would be a happy man if my team mates > > would write code 1/10th as clean as JaCoCo is written ! > > > > -- > > You received this message because you are subscribed to the Google > > Groups "JaCoCo and EclEmma Users" group. > > To unsubscribe from this group and stop receiving emails from it, send > > an email to [email protected] <javascript:>. > > To view this discussion on the web visit > > > https://groups.google.com/d/msgid/jacoco/60521a70-07a1-415e-8d3f-45ddb652e76a%40googlegroups.com > > > [1]. > > For more options, visit https://groups.google.com/d/optout [2]. > > > > > > Links: > > ------ > > [1] > > > https://groups.google.com/d/msgid/jacoco/60521a70-07a1-415e-8d3f-45ddb652e76a%40googlegroups.com?utm_medium=email&utm_source=footer > > > [2] https://groups.google.com/d/optout > > -- You received this message because you are subscribed to the Google Groups "JaCoCo and EclEmma Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jacoco/ec963cc9-f3ff-4851-9b27-4a1f48119198%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
