On Friday, January 5, 2018 at 12:53:04 PM UTC+1, Henning Schild wrote: > Cool, > > thanks for the patches! I just had a quick look and the patches will > likely require quite a few changes before they can get merged. The most > prominent point would be that you create copies of existing files > instead of moving them to common directories and changing them. > This seems to apply to the library as well as the example itself.
That is intentional, since I wanted to isolate my changes as far as possible in order not to risk breaking stuff I don't have the possibility to test. I guess the PCI support could be refactored/redesigned to fit both devices using register based IO and those using MMIO (memory-mapped IO). > > I can offer you to take those patches and rework them for you. If you > are ready to invest more time we could do regular reviews. Yes, that sounds like the way to go. I'd be happy to assist in reviewing. /Jonas > > Henning > > Am Fri, 5 Jan 2018 11:58:21 +0100 > schrieb <[email protected]>: > > > From: Jonas Weståker <[email protected]> > > > > This patch-set contains a bare-metal inmate running an ivshmem-demo > > using the virtual PCI IVSHMEM device provided by the Jailhouse > > hypervisor on BananaPi-M1 (ARM). > > > > Jonas Weståker (4): > > Added virtual PCI support for ARM 32 > > Added bare metal ivshmem-demo inmate for Bananapi > > Added description on how to run bare metal ivshmem-demo on Bananapi > > Added debug printouts for ivshmem memory mismatch in hypervisor > > > > configs/bananapi-ivshmem-demo.c | 111 ++++++++++++++++++++ > > configs/bananapi.c | 2 +- > > configs/bpi-shmem-demo.c | 96 +++++++++++++++++ > > hypervisor/ivshmem.c | 14 +++ > > inmates/demos/arm/HOWTO.md | 42 ++++++++ > > inmates/demos/arm/Makefile | 3 +- > > inmates/demos/arm/ivshmem-demo.c | 190 > > ++++++++++++++++++++++++++++++++++ > > inmates/lib/arm/Makefile | 1 + > > inmates/lib/arm/include/arch/inmate.h | 33 ++++++ > > inmates/lib/arm/pci.c | 70 +++++++++++++ 10 files > > changed, 560 insertions(+), 2 deletions(-) create mode 100644 > > configs/bananapi-ivshmem-demo.c create mode 100644 > > configs/bpi-shmem-demo.c create mode 100644 inmates/demos/arm/HOWTO.md > > create mode 100644 inmates/demos/arm/ivshmem-demo.c > > create mode 100644 inmates/lib/arm/pci.c > > -- You received this message because you are subscribed to the Google Groups "Jailhouse" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
