On Friday, March 22, 2019 at 6:02:02 AM UTC-6, J. Kiszka wrote:
> > +        except OSError as e:
> > +            print(' ERROR: %s' % e)
> 
> Now we have the same error reported twice: once here, and once for the access 
> that fails because we couldn't initialize self.mmap. I'll drop this one while 
> merging.
> 
> Thanks,
> Jan

I guess that's up to you, but I was hoping to give the user some more 
information on why it failed, since when we handle the exception, we are 
suppressing error information.

Currently, we are assuming that the exceptions we catch here are due to 
CONFIG_STRICT_DEVMEM being enabled. If the exceptions are due to some other 
problem, the user might get confused.

-Michael

-Michael

-- 
You received this message because you are subscribed to the Google Groups 
"Jailhouse" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to