Hi all,
On 25/08/2020 16:17, Jan Kiszka wrote:
Hi Thorsten,
please maintain CC lists on reply (AKA reply-to-all).
On 25.08.20 14:48, contact....@gmail.com wrote:
nope,
changed to:
Traceback (most recent call last):
File "tools/jailhouse-cell-linux", line 723, in <module>
config = config_parser.CellConfig.parse(args.config.read())
File "tools/../pyjailhouse/config_parser.py", line 214, in parse
self = cls.parse_class(cls, stream)
File "tools/../pyjailhouse/config_parser.py", line 50, in parse_class
data_tuple = fmt.unpack_from(stream.read(fmt.size))
AttributeError: 'bytes' object has no attribute 'read'
OK, I was only fixing one patch, but the series goes on, and at least
two others ignored jailhouse-cell-linux.
Somehow I missed to refactor this tool. Sorry about that.
Andrej, I'm dropping your series from next again. Please fix and resend.
Ack. Will send a v3 soon'ish.
Thanks,
Andrej Utz
Thanks,
Jan
j.kiszka...@gmail.com schrieb am Dienstag, 25. August 2020 um 12:20:10
UTC+2:
On 25.08.20 10:37, contact....@gmail.com wrote:
> At the current head of the next branch, jailhouse cell linux
throws an
> error:
>
> Traceback (most recent call last):
> File "tools/jailhouse-cell-linux", line 723, in <module>
> config = config_parser.CellConfig(args.config.read())
> TypeError: __init__() takes 1 positional argument but 2 were given
>
> Thorsten
>
> PS sorry for probably replying to the wrong patch-thread
>
No problem - thanks for reporting!
This comes from "pyjailhouse: config_parser: move parsing into class
methods". Does this help?
diff --git a/tools/jailhouse-cell-linux b/tools/jailhouse-cell-linux
index 4178d4e0..aab82a5e 100755
--- a/tools/jailhouse-cell-linux
+++ b/tools/jailhouse-cell-linux
@@ -720,7 +720,7 @@ except IOError as e:
arch = resolve_arch(args.arch)
try:
- config = config_parser.CellConfig(args.config.read())
+ config = config_parser.CellConfig.parse(args.config.read())
except RuntimeError as e:
print(str(e) + ": " + args.config.name <http://args.config.name>,
file=sys.stderr)
exit(1)
Then I will fold it into Andrej's commit.
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
--
You received this message because you are subscribed to the Google
Groups "Jailhouse" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to jailhouse-dev+unsubscr...@googlegroups.com
<mailto:jailhouse-dev+unsubscr...@googlegroups.com>.
To view this discussion on the web visit
https://groups.google.com/d/msgid/jailhouse-dev/bddbb89a-01c3-4d34-9821-405ec8dcffe5n%40googlegroups.com
<https://groups.google.com/d/msgid/jailhouse-dev/bddbb89a-01c3-4d34-9821-405ec8dcffe5n%40googlegroups.com?utm_medium=email&utm_source=footer>.
--
You received this message because you are subscribed to the Google Groups
"Jailhouse" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jailhouse-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/jailhouse-dev/e3d8f4e7-54aa-0c4f-0f71-ec688b4269e7%40st.oth-regensburg.de.
