cvs commit: jakarta-commons-sandbox/util/src/test/org/apache/commons/util StringUtilsTest.java

[dlr]

dlr         01/08/25 21:39:52

  Modified:    util/src/test/org/apache/commons/util StringUtilsTest.java
  Log:
  Improved tests for isValid() and isEmpty().
  
  Revision  Changes    Path
  1.5       +6 -2      
jakarta-commons-sandbox/util/src/test/org/apache/commons/util/StringUtilsTest.java
  
  Index: StringUtilsTest.java
  ===================================================================
  RCS file: 
/home/cvs/jakarta-commons-sandbox/util/src/test/org/apache/commons/util/StringUtilsTest.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -u -r1.4 -r1.5
  --- StringUtilsTest.java      2001/08/26 02:07:39     1.4
  +++ StringUtilsTest.java      2001/08/26 04:39:52     1.5
  @@ -73,6 +73,8 @@
   
       private static final String TEXT_LIST = "foo,bar,baz";
   
  +    private static final String FOO = "foo";
  +
       public StringUtilsTest(String name)
       {
           super(name);
  @@ -88,8 +90,10 @@
       protected void runTest()
           throws Throwable
       {
  -        assert("isValid(String) failed", StringUtils.isValid("foo"));
  -        assert("isEmpty(String) failed", StringUtils.isEmpty("   "));
  +        assert("isValid(String) failed",
  +               StringUtils.isValid(FOO) && !StringUtils.isValid(""));
  +        assert("isEmpty(String) failed",
  +               StringUtils.isEmpty("   ") && !StringUtils.isEmpty(FOO));
   
           assertEquals("join(Object[], String) failed", TEXT_LIST,
                        StringUtils.join(ARRAY_LIST, SEPARATOR));