Hi,

I have given my vote for beta1. I hesitated with libraries which I have 
not actually used. For the moment I left most of these blank.

I noticed that only votes for the libraries were brought out, not for 
the blink and other samples.  Maybe we don't need to vote, why not make 
all samples part of the beta1 (like all device files)?

I was about to vote for the temp_tc77 library. I have used the TC77 in 
the past and also some similar chips like the LM74 (but not with JAL), 
so I was interested.
While looking at the source I noticed some 'irregularities':
- some global variables (SIO and SCK) are in upper case and without
   prefix temp_
- delay_1ms is called without '()'
- the read_ procedures do not start with temp_
BTW I don't really like the prefix 'temp_', smells too much to 
'temporary'. What about changing it to 'thermo_'?

The CO2 library has similar deviations from our naming conventions (no 
CO2-prefix for global variables/constants and procedures/functions).

Some more nitpicking:
Of the pic_data_eeprom library the 'pic_' prefix should be removed from 
its name.
The data_eeprom, adc, pwm, serial_hardware, serial_software libs have 
not the 3-byte indent.
Several samples have also not the 3 char indent.

These should be fixed before release.

Seb, do you have a script to compile all samples? Some are not updated 
after changes in the libraries and it would be useful as last minute check.



Regards, Rob.

-- 
Rob Hamerling, Vianen, NL (http://www.robh.nl/)

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"jallib" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/jallib?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to