Hi Seb, This is not necessary, since init procedure already takes a param to switch start/stop interrupts. I understand when setting this in library, users won't have to care about passing "true" to the init procedure, but this is somewhat confusing because there's two of achieving the same thing. We should keep only one. I missed that... And yes, we should keep one!
I agree to keep your if you prefer it. I don't mind either way. Note that I did not only use this constant here, but also to call the two extra isr_handlers. Maybe I could have added this to the error handler, but one of the bits I need is masked and the error handler does not get the status data (maybe it should). I'd need to update the blog... How can we deal with that ? In my posts, I point to SVN repository, but since it evolves, posts become outdated and things may not work anymore. I can't attach files, because this crap can't handle them. I may upload files in group's file section, specially for blog, as I already did for my LCD sample. I'd then just need to update the posts to say "hey, something has evolved" but without modifying the whole content. Do you guys have any other idea ? I thought about this too, since I made usart_hw_serial next-to obsolete and don't want to bother people with that. I think we should update the blog, so there is no outdated info there. So users may need to upgrade to the newest version of jallab, but that is what they should do anyway. There is however a timing issue: do we update the blog now or whith the next release of jallib? I've seen you enriched the ISR to conditionally add _on_start and _on_stop interrupts, this is great and powerful :) Thanks. Joep 2009/1/28 Joep Suijs <[email protected]> > >> Hi all, >> >> The i2c slave with message interface seems to work okay now and to achieve >> this, i2c_hw_slave_isr is extended to (optionally) support start and stop >> interrupts.See test_i2c_hw_slave_msg to see how simple i2c can be. Please >> have a look and give it a try if you can. >> >> Joep >> >> >> > > > -- > Sébastien Lelong > http://www.sirloon.net > http://sirbot.org > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/jallib?hl=en -~----------~----~----~----~------~----~------~--~---
