Hi, Looks great ! Just a few words though... Sometimes, looking at the signature, it's like the functions' name contain the signature itself. Ex:
lcd_bvalue_dp_line_pos_left_sign( byte in value, byte in dp, byte in line, byte in poskar, bit in left, bit in sign ) After "lcd_" prefix, in the name we have: - dvalue - dp - line - pos - left - sign Same for signature. While it can help remember which argument goes where, it makes the procedure's name quite long. Maybe just "lcd_bvalue_dp(...) would be enough ? (also careful, "poskar" doesn't sound like an english word....) Just my 2c. Cheers, Seb > > Hi all, > > > > I commited a new ng_hd44780_4 lib. I tested it with the test program > and looks okay. > It is compatible with lcd_hd44780_4 lib but: > - also supports datalines that can be on different ports (code > provided by Richard) > - uses lcd_hd44780_common for the user-functions. > - This lib provides much more functions then then lcd_44780 did. > - This lib can be resused with other interfaces > > Please take a look at the API in lcd_hd44780_common - is it like it > should be? And especially to Wayn: to which degree do you think would > this be suitable as the K107 library API? > > Richard provided a file with lot of lcd code and I probably turn that > into a test file to test the lib and demonstate the features. > > I intend to remake the 8-bit version too. Is there someone with a lcd > connected in 8-bit mode that can test this? > > Tnx, > Joep > > > > -- Sébastien Lelong http://www.sirloon.net http://sirbot.org --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/jallib?hl=en -~----------~----~----~----~------~----~------~--~---
