Another option is too remove pintools_set_level(), as you suggested from the beginning :) Looking at the sample, code is indeed cleaner...
Seb 2010/5/19 Sebastien Lelong <[email protected]> > Hi Matt, > > I had a very quick look, it seems some portions of code have been > duplicated between pintools_set_level() and pintools_level'put for instance. > I guess you didn't want to call pintools_set_level() from pseudo-array func > to save a stack ? Did you try with "pragma inline" ? > > Another alternative is to produce the code from a template, where there > would be only one version of the code, no duplication. Another is to let > this as is, since I don't think it will change often. But this can be a > source of bug (fixed in pintools_set_level(), not in pintools_level'put) > > What's your opinion on this ? > > Cheers, > Seb > > > 2010/5/19 mattschinkel <[email protected]> > > Seb, can you please take a look. >> >> >> ty >> Matt. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "jallib" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]<jallib%[email protected]> >> . >> For more options, visit this group at >> http://groups.google.com/group/jallib?hl=en. >> >> > > > -- > Sébastien Lelong > http://www.sirloon.net > http://sirbot.org > -- Sébastien Lelong http://www.sirloon.net http://sirbot.org -- You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/jallib?hl=en.
