The point is that the inline statements, as currently placed, do not accomplish what Seb intended for them to do -- he said he wanted to generate the same hex code as the previous version, but it can not do so as written, but with a very minor edit, it might well do so. See above for details.
In all of your many tests during the past two weeks, did you happen to do any CANbus testing? In particular, any that use the can_mcp2515.jal library? Thank you, William On May 4, 5:21 pm, mattschinkel <[email protected]> wrote: > The pragma inline statements and Seb's new modifications have been > tested well. Both of us have tested it on a many PIC's and devices. > > Matt. > > On May 4, 10:41 am, William <[email protected]> wrote: > > > > > > > > > Hi Seb, > > > Thank you for your changes. I have one other question/issue -- if you > > want to attempt to maintain 'hex file' compatibility with the original > > library, it seems to me you need to make a minor change in the way you > > are using 'inline' -- it should be added to both of the new routines, > > but not the original spi_init routine. > > > William > > > On May 4, 2:47 am, Sebastien Lelong <[email protected]> > > wrote: > > > > 2011/5/4 William <[email protected]> > > > > > Seb, > > > > > That is surprising, since you added an inline statement to your > > > > version of spi_init. > > > > Yes, to make it equivalent as before. > > > > > Please add your name to the files as requested. > > > > Adapted-by. I don't own the authorship of spi_master_hw2.jal. My > > > contribution was to "sed" register names... > > > > Cheers, > > > Seb > > > > > On May 4, 2:08 am, Sebastien Lelong <[email protected]> > > > > wrote: > > > > > Hi William, > > > > > > Le 4 mai 2011 à 09:02, William <[email protected]> a écrit : > > > > > > > I hope you re-tested all of the existing samples that were using the > > > > > > library also, on real hardware? :-) > > > > > > IIRC I compared generated HEX file's md5sum before and after > > > > > refactoring. They were the same. > > > > > > Cheers > > > > > Seb > > > > > > > On Apr 19, 5:07 am, [email protected] wrote: > > > > > >> Revision: 2583 > > > > > >> Author: sebastien.lelong > > > > > >> Date: Tue Apr 19 03:06:45 2011 > > > > > >> Log: added SPI Master lib running MSSP2 module, refactored > > > > > >> common > > > > > >> constants to spi_master_common.jalhttp://code.google.com/p/jallib/ > > > > > >> source/detail?r=2583 > > > > > > >> Added: > > > > > >> /trunk/include/peripheral/spi/spi_master_common.jal > > > > > >> /trunk/include/peripheral/spi/spi_master_hw2.jal > > > > > >> Modified: > > > > > >> /trunk/include/peripheral/spi/spi_master_hw.jal > > > > > > > -- > > > > > > You received this message because you are subscribed to the Google > > > > > > Groups "jallib" group. > > > > > > To post to this group, send email to [email protected]. > > > > > > To unsubscribe from this group, send email to > > > > [email protected] > > > > > > . > > > > > > For more options, visit this group athttp:// > > > > groups.google.com/group/jallib?hl=en > > > > > > . > > > > > -- > > > > You received this message because you are subscribed to the Google > > > > Groups > > > > "jallib" group. > > > > To post to this group, send email to [email protected]. > > > > To unsubscribe from this group, send email to > > > > [email protected]. > > > > For more options, visit this group at > > > >http://groups.google.com/group/jallib?hl=en. > > > > -- > > > Sébastien Lelonghttp://www.sirloon.nethttp://sirbot.org -- You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/jallib?hl=en.
