Hi Urmas,

On 07.11.14 19:51, Urmas Joeleht wrote:

I added Microchip serial flash library and sample. I'm using those in
data loggers where 8...64Mb Flash is enough. Cheap, no moving parts or
contacts, works in minus temperatures also.

I had a quick look in the source of the sample and have some comments:

Name:
The primary purpose of the sample is (I think) to demonstrate the use of the sst25vf library. So why not call it simply 18f27j53_sst25vf.jal without the 'pps'. You need may PPS but it is not very relevant for the sample.

Serial interface:
You declare things like 'serial_ctsinv', SERIAL_OVERFLOW_DISCARD, SERIAL_XMTBUFSIZE and some more. But these are irrelevant for for the 'serial_hardware' library which you use, which is unbuffered (apart from 2 bytes hardware buffer). The lines are needed by the 'serial_hw_int_cts' library. So you should remove these lines or use the serial_hw_int_cts library.

Regards, Rob.



--
R. Hamerling, Netherlands --- http://www.robh.nl

--
You received this message because you are subscribed to the Google Groups 
"jallib" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/jallib.
For more options, visit https://groups.google.com/d/optout.

Reply via email to