Re: [V2.1.1]: NNTP patch

[Aaron Knauf]

Noel J. Bergman wrote:

There are in my mind a number issues with the current code.
There are parts of refactoring that make things difficult
as we go forward. I will be happy elaborate post tests.

Why don't you elaborate now?  What specific technical issues do you have
with the current code?

FWIW, I agree that the current bug reports are too vague.

I know absolutely nothing about NNTP, but from reading the posts pertaining to this issue, I gather that the MODE and XOVER commands are broken. How they are broken, and the effect that this has is not made clear.

Including the following information in the bug report would (IMHO) make the discussions on this subject more productive:

1) A brief description of the error, including the specific wording of any error messages displayed.
2) Instructions on how to reproduce the error.
3) A description of the effect that this has on the application's operation. (To be used in determining the priority given to fixing the problem.)


Of particular concern to me is the fact that there is only one bug description (vague as it is) supplied, while there is consistent allusion to multiple bugs. The above information should be supplied *for each* bug.

As for the patches I have, I have submitted them for review, I do plan to
test them, and if they work, I see no reason why we should not use them.
But I am also willing to see what you have in mind.

As far as I can see, only one set of fixes has been proposed. There are three options from here:

1) If the fixes work +1 them and get on with it.
2) If the fixes don't work, or break something else, -1 them.
3) If the fixes do work, but you don't like the implementation, suggest a better alternative. If you don't have a better alternative, (this need not be fully working code, just suggestions) then let the fix go in and refactor later.

As for a test suite, this is very desirable. I could tell many success stories about the usefullness of JUnit test suites during code refactoring.

However, in the absence of a test suite, I don't think anyone really wants the NNTP code to stay broken until someone gets around to writing one. Especially with a fix already submitted.

JUnit tests are simply a way of automating the regression testing process. It ought to be relatively simple to verify this fix through manual testing.

That was my 2 shekels worth, anyway.

Cheers

ADK



--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>