NullPointerException in org.apache.james.smtpserver.SMTPHandler

[Marcos Sanz/Denic]

Hi,

I have some NullPointerExceptions in my log file because of this line:

final String readCommandLine() throws IOException {
      return inReader.readLine().trim();
}

Wouldn't it be much smarter:

final String readCommandLine() throws IOException {
      String line = inReader.readLine();
      if (null == line)
            return null
      else
            return line.trim();
}

I don't think it breaks any code this way.

Regards,
Marcos Sanz
DENIC eG



--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>