Thanks Noel for the review of the CIDR code that was
submitted
(http://www.mail-archive.com/james-dev@jakarta.apache.org/msg06695.html)
..
 
Your modifications are excellent - tighter and cleaner
code.
 
After spending a little more time with
live-testing, I have only found a problem with the
GeneriocNetworkMatcher:init(); the order in which the check
for localhost, explicit address, wildcard match was wrong.
The check for wildcard match needs to be before the explicit
address check.
 
I've made this correction and added a bit to the
documentation. 
 
Currently this code is in use at a commercial ISP and is
differentiating between ~200 distinct networks.
 
Please accept the attached Networks.Zip for inclusion in the
next regular release of James.
 
(when you guys get a chance to breathe of course!!)



_______________________
Alan Gerhard
Gerhard Computing, Inc.
1-860-355-8610
1-860-355-9041
[EMAIL PROTECTED]

Attachment: Network.zip
Description: Zip compressed data

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to