Lo Giacco Roberto
----- Original Message -----
From: Federico Barbieri <[EMAIL PROTECTED]>
To: Java Apache Mail Server <[EMAIL PROTECTED]>
Sent: Wednesday, January 12, 2000 8:06 PM
Subject: SMTPHandler
> I spent some time on SMTP protocol hadler pattern and I realyze a couple
> of things:
>
> First (really sorry to say that) the code is really bad written.
> I'm not pointing my finger on anyone but code like ...
>
> public InputStream getBodyInputStream() {
> if ( in == null ) { return null; }
> return in;
> }
>
> really sucks!
Yep! That's the right way to have an headhache! A method to check nullity of
an attribute? :-))
> Second IMHO pluggable commands do not provide any real avantages but
> makes only more complex changes and debugging. Since the protocol is
> well defined I far prefere a simple hardcoded class implementing all
> commands than spagetti coding.
> If we'll decide to implements some ESMTP commands we'll write an
> ESMPTHandler supporting specific commands. If I need to extend support
> to a new command it's far more easy modify update the class than adding
> a new command.
+1
I agree with yor view but I like very much protocol extensibility for
special behaviours. If we can still have this extension support... than
totally agree with you...too much code for a so well defined protocol!
> That's way I'm planning to roll back to the old SMTP handler, fix and
> update it if necessary and add the LocalInbox feature. I've worked a bit
> on the Store interface and IMO it's ready to support local users and
> inbox for local delivery throught POP3.
>
> If everybody agree I'll do the job.
>
> We really need a nice working .jar if we want to break this stillness.
I'm not yet get so confident with the code to be useful to the project...I'm
not used to workgroup...sorry. I'm really trying to build up something...
>
> --
> Federico
>
> *-----------------------------------*
> "Troubles occurr when two people try
> to be intelligent in the same time."
> - Murphy
> *-----------------------------------*
>
>
>
> ------------------------------------------------------------
> To subscribe: [EMAIL PROTECTED]
> To unsubscribe: [EMAIL PROTECTED]
> Archives and Other: <http://java.apache.org/>
> Problems?: [EMAIL PROTECTED]
>
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Archives and Other: <http://java.apache.org/>
Problems?: [EMAIL PROTECTED]
