2009/7/15 Eduard - Gabriel Munteanu <eduard.munte...@linux360.ro>:
> Provide a test case for passing lots of parameters. This proves useful
> to test things such as register parameters.
>
> Signed-off-by: Eduard - Gabriel Munteanu <eduard.munte...@linux360.ro>
Two comments, see below :-)
> ---
> Makefile | 1 +
> regression/jvm/ParameterPassingTest.java | 43
> ++++++++++++++++++++++++++++++
> 2 files changed, 44 insertions(+), 0 deletions(-)
> create mode 100644 regression/jvm/ParameterPassingTest.java
>
> diff --git a/Makefile b/Makefile
> index 23e766b..bada96a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -248,6 +248,7 @@ REGRESSION_TEST_SUITE_CLASSES = \
> regression/jvm/ObjectCreationAndManipulationExceptionsTest.class \
> regression/jvm/ObjectCreationAndManipulationTest.class \
> regression/jvm/ObjectStackTest.class \
> + regression/jvm/ParameterPassingTest.class \
> regression/jvm/PrintTest.class \
> regression/jvm/PutfieldTest.class \
> regression/jvm/PutstaticPatchingTest.class \
> diff --git a/regression/jvm/ParameterPassingTest.java
> b/regression/jvm/ParameterPassingTest.java
> new file mode 100644
> index 0000000..15b86bf
> --- /dev/null
> +++ b/regression/jvm/ParameterPassingTest.java
> @@ -0,0 +1,43 @@
> +/*
> + * Copyright (C) 2006 Eduard - Gabriel Munteanu <eduard.munte...@linux360.ro>
> + *
> + * This file is released under the GPL version 2 with the following
> + * clarification and special exception:
> + *
> + * Linking this library statically or dynamically with other modules is
> + * making a combined work based on this library. Thus, the terms and
> + * conditions of the GNU General Public License cover the whole
> + * combination.
> + *
> + * As a special exception, the copyright holders of this library give you
> + * permission to link this library with independent modules to produce an
> + * executable, regardless of the license terms of these independent
> + * modules, and to copy and distribute the resulting executable under
> terms
> + * of your choice, provided that you also meet, for each linked
> independent
> + * module, the terms and conditions of the license of that module. An
> + * independent module is a module which is not derived from or based on
> + * this library. If you modify this library, you may extend this
> exception
> + * to your version of the library, but you are not obligated to do so. If
> + * you do not wish to do so, delete this exception statement from your
> + * version.
> + *
> + * Please refer to the file LICENSE for details.
> + */
> +package jvm;
> +
> +import jato.internal.VM;
> +
> +/**
> + * @author Eduard - Gabriel Munteanu
> + */
> +public class ParameterPassingTest {
> + public static int add(int a, int b, int c, int d, int e,
> + int f, int g, int h, int i, int j) {
> + return a + b + c + d + e + f + g + h + i + j;
> + }
> +
> + public static void main(String[] args) {
> + VM.exit(add(1, 2, 3, 4, 5, 6, 7, 8, 9, 10));
I think we can improve this by extending the TestCase class and using
assertEquals, i.e.:
int result = add(1, 2, 3, 4, 5, 6, 7, 8, 9, 10);
assertEquals(result, 55);
and that means we don't need the exit() (nor the "import for VM").
> + }
> +}
> +
> --
> 1.6.0.6
Also, shouldn't this test-case be added to regression/run-suite.sh as well?
Vegard
------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
Jatovm-devel mailing list
Jatovm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jatovm-devel
