[
https://issues.apache.org/jira/browse/AXIS2-6044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895225#comment-17895225
]
Christian Ortlepp commented on AXIS2-6044:
------------------------------------------
I think the change in precedence sounds reasonable, I drafted something
[here|[https://github.com/apache/axis-axis2-java-core/pull/796].] This is not
yet tested, but since I'm not using this feature I also cannot really test it
manually. There are also no unit tests yes (as far as I can tell), and I don't
have a good idea yet on how to write a sensible one. Note on the
implementation: For some reason the code used to check lower precedence first,
although this seems superfluous if a higher precedence config applies. But in
case I missed some side effect (maybe the configuration can "spill" from a
lower precedence to a higher one?) I kept this behavior and simply moved the
system properties to the lowest precedence (i.e. checking it first and not last
as before).
To your second point: As far as I can tell we only support HTTP proxies in
general, I could not find anything regarding HTTPS proxy configuration
anywhere. So this is not an issue with the system property configuration, this
is just not available as a feature (correct me if I'm wrong). As such, I think
this is out of scope for this issue and probably also 2.0.0. If you care about
this you can open a feature request.
[~tejmeh] if you could provide some feedback if this fixes your issue that
would be great.
> HTTPProxyConfigurator system property takes precedence over axis
> configuration and message context proxy properties
> -------------------------------------------------------------------------------------------------------------------
>
> Key: AXIS2-6044
> URL: https://issues.apache.org/jira/browse/AXIS2-6044
> Project: Axis2
> Issue Type: Bug
> Components: transports
> Affects Versions: 1.7.9
> Reporter: tejas mehendale
> Assignee: Robert Lazarski
> Priority: Blocker
> Fix For: 2.0.0
>
>
> Refer classes ->
> org.apache.axis2.transport.http.impl.httpclient4.HTTPProxyConfigurator
> -> method -> configure
> Also,
> org.apache.axis2.transport.http.impl.httpclient3.HTTPProxyConfigurator ->
> method -> configure
> 1 -
> In this method , axis2.xml configuration file is referred 1st for proxy
> settings which is overridden if set by messageContext proxy properties which
> is overridden by system property if set for proxy settings
> now, lets say we have multiple integrations in our system and few of
> integrations use system level proxy settings and few other require some other
> proxy setting depending on flow/input then , this is not possible to achieve
> since system properties ultimately overrides what is set in message context
> we think that precedence should be like , check 1st system properties if set
> then if axis2 configuration is set then override system properties and then
> check. if messageCOntext proxy properties is set then it should be used
> overriding axis2 config. properties or system properties , that way when a
> system is calling multiple integration points that system get to choose which
> proxy setting is used by an integration be setting proxy settings in
> messageContext property
> 2 -
> 2nd issue is -> for point 1 above for system properties , it does not
> consider https.proxyHost and https.proxyPort from system properties it checks
> only "http" system properties and not "https" , need support for same
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
