cortlepp commented on PR #1133: URL: https://github.com/apache/axis-axis2-java-core/pull/1133#issuecomment-3989403646
@robertlazarski in [this CI run](https://github.com/apache/axis-axis2-java-core/actions/runs/22310813617/job/64542114888?pr=1133#step:5:9865) on this MR your http 3 streaming benchmark failed again due to timing issues. Again, can we please disable these benchmarks-as-tests by default? If you want to run them yourself when you change something in the implementation that's fine, we can keep them and mark them as disabled, but benchmarks are just not suitable to run as a unit test in CI where reproducibility is key. We will never be able to predict how fast our github actions runner is at some point in time, and we really shouldn't try to. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
