[
https://issues.apache.org/jira/browse/AXIS2-6040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18075179#comment-18075179
]
Robert Lazarski commented on AXIS2-6040:
----------------------------------------
Follow-up: commit 93a795320e fixes two issues caught in post-push review:
▎ 1. transport-local uses <packaging>bundle</packaging> (OSGi), so the
maven-jar-plugin config I added was silently ignored — the
maven-bundle-plugin generates the manifest, not maven-jar-plugin. Moved the
Automatic-Module-Name into the bundle plugin's
<instructions> block where it actually gets written. The other 23 modules use
standard JAR packaging and are unaffected.
▎ 2. Removed a proprietary organization reference from the parent POM
developer block — unrelated to this issue but caught during the
review.
▎ The jar --describe-module verification I mentioned should now work
correctly for all 24 modules including transport-local. GHA CI
will confirm.
> Define Automatic-Module-Name for Java9 module system compatibility
> ------------------------------------------------------------------
>
> Key: AXIS2-6040
> URL: https://issues.apache.org/jira/browse/AXIS2-6040
> Project: Axis2
> Issue Type: Improvement
> Components: kernel
> Affects Versions: 1.8.2
> Reporter: Wolfgang Knauf
> Priority: Minor
> Fix For: 2.0.1
>
>
> After Java9 module system compatibility was fixed through
> https://issues.apache.org/jira/browse/AXIS2-4311, I used Eclipse to create a
> "module-info.java" to my small sample project.
> This is the resulting module-info.java file:
> {{module myprojectname}}
> {
> {{ exports my.own.project.package;}}
> {{ requires axiom.api;}}
> {{ requires axis2.adb;}}
> {{ requires axis2.kernel;}}
> {{ requires commons.logging;}}
> {{ requires jakarta.activation;}}
> {{ requires java.rmi;}}
> {{ requires java.xml;}}
> {{}}}
>
> This results in four eclipse warnings:
> {{Name of automatic module 'axiom.api' is unstable, it is derived from the
> module's file name.}}
> {{Name of automatic module 'axis2.adb' is unstable, it is derived from the
> module's file name.}}
> {{Name of automatic module 'axis2.kernel' is unstable, it is derived from the
> module's file name.}}
> {{Name of automatic module 'commons.logging' is unstable, it is derived from
> the module's file name.}}
> As far as I understand it, it would be sufficient to add a
> "Automatic-Module-Name" entry to Manifest.mf for the Axis2 jars- see e.g.
> [https://github.com/ReactiveX/RxJava/issues/5618]
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
