Doug Cutting wrote:

[EMAIL PROTECTED] wrote:

--- lucene/java/trunk/src/java/org/apache/lucene/store/FSDirectory.java (original) +++ lucene/java/trunk/src/java/org/apache/lucene/store/FSDirectory.java Mon Jun 6 10:52:12 2005
@@ -52,8 +52,8 @@
         if (name.endsWith("."+IndexReader.FILENAME_EXTENSIONS[i]))
           return true;
       }
-      if (name.equals("deletable")) return true;
-      else if (name.equals("segments")) return true;
+      if (name.equals(Constants.INDEX_DELETABLE_FILENAME)) return true;
+ else if (name.equals(Constants.INDEX_SEGMENTS_FILENAME)) return true;
       else if (name.matches(".+\\.f\\d+")) return true;
       return false;


This really belongs in the index package. That way, when we change the set of files in an index, the changes will be localized.

So this, LuceneFileFilter, Constants.INDEX_* and IndexReader.FILENAME_EXTENSIONS, should all be moved to a common home in the index package, like org.apache.lucene.index.IndexFileNames. Thoughts?

yes, this makes sense. I will try to pack all the spreaded filenames and extensions together in a new class org.apache.lucene.index.IndexFileNames. So we have everything in one place and it will be much easier to maintain or even to change.

Bernhard


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to