[ 
http://issues.apache.org/jira/browse/LUCENE-475?page=comments#action_12359083 ] 

Bernhard Messer commented on LUCENE-475:
----------------------------------------

I like the patch and find it very helpful if one tries to load larger indices 
into RAMDirectory.

Hoss Man,

why do you would like to have a new constructor to adjust the internal buffer 
size. I do not see any reason to make the buffersize configurable from outside. 
The tests i made with different sizes didn't show any difference on performace 
or disk usage. The new implementation would be similar to BufferedIndexOutput 
where the internal buffer size couldn't be changed either. Do i miss something ?


>  RAMDirectory(Directory dir, boolean closeDir)  constructor uses memory 
> inefficiently.
> --------------------------------------------------------------------------------------
>
>          Key: LUCENE-475
>          URL: http://issues.apache.org/jira/browse/LUCENE-475
>      Project: Lucene - Java
>         Type: Improvement
>   Components: Store
>     Reporter: Volodymyr Bychkoviak
>  Attachments: RamDirectory.diff
>
> recently I found that  RAMDirectory(Directory dir, boolean closeDir)  
> constructor uses memory inefficiently.
> files from source index are read entirely intro memory as single byte array 
> which is after all is thrown away. And if I want to load my 200M optimized, 
> compound format index to memory for faster search I should give JVM at least 
> 400Mb memory limit. For larger indexes this can be an issue.
> I've attached patch how to solve this problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to